ACS: Decrease Player Speed Depending On Item Weight

[CaptainNurbles]

I'm working out a sort of encumbrance system which limits the player's ability to carry tons of gear. It's mostly functional, but I know bugger all about ACS and have been having a hard time figuring out how to make the encumbrance part work.

Whenever the player picks up a weapon, inventory item, or piece of armor, it adds a set amount of an inventory item - WeaponBulk. A 10mm pistol adds 12 units. The hard limit is 1200 WeaponBulk units, and after that the player can carry no more. This aspect functions perfectly adequately.

What I'm needing is a separate ACS script which decreases the player's speed based on how much of that WeaponBulk item they have. I've taken some previous scripts used in my mod and attempted to reverse engineer something together, but haven't been super lucky just yet.

Code: Select all

Script "InventorySpeedSystem" ENTER
{
   While(true)
   {
   Delay(1);
   If(CheckActorInventory(0,"WeaponBulk">149)){SetActorProperty(0, APROP_SPEED, 0.75);}
   If(CheckActorInventory(0,"WeaponBulk">299)){SetActorProperty(0, APROP_SPEED, 0.7);}
   If(CheckActorInventory(0,"WeaponBulk">399)){SetActorProperty(0, APROP_SPEED, 0.55);}
   If(CheckActorInventory(0,"WeaponBulk">599)){SetActorProperty(0, APROP_SPEED, 0.4);}
   If(CheckActorInventory(0,"WeaponBulk">799)){SetActorProperty(0, APROP_SPEED, 0.25);}
   If(CheckActorInventory(0,"WeaponBulk">999)){SetActorProperty(0, APROP_SPEED, 0.1);}
   Restart;
   }
}

[Jarewill]

The main reason why it isn't working is because you put the condition check in the wrong place.
Instead of If(CheckActorInventory(0,"WeaponBulk">149))
You should use If(CheckActorInventory(0,"WeaponBulk")>149)

A few more notes.
Since it's an ENTER script, CheckInventory can be used instead of CheckActorInventory as the player is the activator.
Restart is not needed as the While will loop without it.
Remember to reset the speed back to 1.0 if none of the conditions pass.

[CaptainNurbles]

Well, it partially works! Did as you had recommended and when I'm at the 1,000 bulk threshold it does slow me down significantly. Anything before that however, no difference in speed.

Code: Select all

Script "InventorySpeedSystem" ENTER
{
   While(true)
   {
   Delay(1);
   If(CheckInventory("WeaponBulk")>149){SetActorProperty(0, APROP_SPEED, 0.9);}
   If(CheckInventory("WeaponBulk")>299){SetActorProperty(0, APROP_SPEED, 0.8);}
   If(CheckInventory("WeaponBulk")>399){SetActorProperty(0, APROP_SPEED, 0.65);}
   If(CheckInventory("WeaponBulk")>599){SetActorProperty(0, APROP_SPEED, 0.4);}
   If(CheckInventory("WeaponBulk")>799){SetActorProperty(0, APROP_SPEED, 0.25);}
   If(CheckInventory("WeaponBulk")>999){SetActorProperty(0, APROP_SPEED, 0.1);}
   Else
   SetActorProperty(0,APROP_SPEED,1.0);
   }
}

[Jarewill]

Your Else block is put in such a place that it will always trigger below the 1000 threshold.
To fix this, you can either put it at the very beginning outside any blocks, like this:

Code: Select all

   ....
   Delay(1);
   SetActorProperty(0,APROP_SPEED,1.0);
   If(CheckInventory("WeaponBulk")>149){SetActorProperty(0, APROP_SPEED, 0.9);}
   ....

Or by altering the script's logic, like this:

---

Code: Select all

Script "InventorySpeedSystem" ENTER
{
   While(true)
   {
   Delay(1);
   If(CheckInventory("WeaponBulk")<150){SetActorProperty(0, APROP_SPEED, 1.0);}
   Else If(CheckInventory("WeaponBulk")<300){SetActorProperty(0, APROP_SPEED, 0.9);}
   Else If(CheckInventory("WeaponBulk")<400){SetActorProperty(0, APROP_SPEED, 0.8);}
   Else If(CheckInventory("WeaponBulk")<600){SetActorProperty(0, APROP_SPEED, 0.65);}
   Else If(CheckInventory("WeaponBulk")<800){SetActorProperty(0, APROP_SPEED, 0.4);}
   Else If(CheckInventory("WeaponBulk")<1000){SetActorProperty(0, APROP_SPEED, 0.25);}
   Else{SetActorProperty(0, APROP_SPEED, 0.1);}
   }
}

[CaptainNurbles]

That's the ticket! Much appreciated.

[Graaicko]

This has some Escape from Tarkov vibes.

[Kaution]

Agent ME did this:

viewtopic.php?p=417383#p417383