Server CVARs can be changed by any player

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
Player701
 
 
Posts: 1394
Joined: Wed May 13, 2009 3:15 am
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support
Location: Russia

Server CVARs can be changed by any player

Post by Player701 »

See here. Basically, it appears that any player in a netgame can change any server CVAR (wherher built-in or CVARINFO-defined). This should only be allowed for the hosting player.

Bisecting indicates the offending commit to be this one. It is referenced in this bug report, where the problem was that no one at all could change server CVARs. With another bisect, I've established that the other bug was caused by this commit, though I'm not sure if this information could be useful.
_mental_
 
 
Posts: 3771
Joined: Sun Aug 07, 2011 4:32 am

Re: Server CVARs can be changed by any player

Post by _mental_ »

Fixed in 8a4b8cc.
User avatar
Player701
 
 
Posts: 1394
Joined: Wed May 13, 2009 3:15 am
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support
Location: Russia

Re: Server CVARs can be changed by any player

Post by Player701 »

Fix confirmed. Thank you very much :)

Return to “Closed Bugs”