FMultiPatchTexture Infinite Recursion

[Major Cooke]

Uncertain as to how this happens but I think what goes on is, if someone redefines a sprite while still using the "Patch" word and encounters that sprite, this happens.

Code: Select all

bool FMultiPatchTexture::UseBasePalette() 
{ 
	if (bComplex) return false;
	for(int i=0;i<NumParts;i++)
	{
		if (!Parts[i].Texture->UseBasePalette()) return false;
	}
	return true;
}

[Graf Zahl]

This looks like some texture found itself as patch. Do you have the definition that causes it?

[Major Cooke]

Yep. Normally I use this for the sake of rotating things but since that appears dangerous now, I'll avoid this type of practice. Also it doesn't matter if it's patch or sprite defined. Both cause recurrences.

Code: Select all

Sprite X153A0, 256, 256
{
	Offset 128, 128
	Sprite X153A0, 0, -1
	{
		Rotate 90
	}
}

[Graf Zahl]

Yeah, not surprising. You actually declared the texture you defined as patch to be used. I'll add a check to skip such definitions and go for the previous one with the same name