Pull Request
Having armor absorbing 100% of the damage revealed it doesn't take ALLOWPAIN and CAUSEPAIN into account.
Allow/CausePain Armor Fix
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
- Major Cooke
- Posts: 8212
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Operating System Version (Optional): Windows 10
- Graphics Processor: nVidia with Vulkan support
- Location: GZBoomer Town
- Contact:
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49234
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Allow/CausePain Armor Fix
Please give a bit more information. What precise case was not handled. Upon a quick look I cannot make much sense out of that fix.
- Major Cooke
- Posts: 8212
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Operating System Version (Optional): Windows 10
- Graphics Processor: nVidia with Vulkan support
- Location: GZBoomer Town
- Contact:
Re: Allow/CausePain Armor Fix
There simply was no special case handling for PLAYER armor (NOT monster armor, that's already covered!) when it absorbs all damage (think SavePercent set to 100, AEoD has this). I'm working on a new powerup that relies upon the player entering the pain state, so I gave the player +ALLOWPAIN in the hopes it would work every time they took a hit with that armor. Unfortunately, it didn't work, so that's what this pull request addresses.
- Major Cooke
- Posts: 8212
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Operating System Version (Optional): Windows 10
- Graphics Processor: nVidia with Vulkan support
- Location: GZBoomer Town
- Contact:
Re: Allow/CausePain Armor Fix
Is this ready to be looked into?
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49234
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Allow/CausePain Armor Fix
I can only take your word for it because to me that code is utterly obtuse.