[ZDoom 2.8.X] W7x64 Event Viewer spam: "SxS Error 80"

[Medicris]

I'm not sure where this should be posted, but it does coincide with the update to 2.8.0 and continues to .1. Lately my Event Viewer log as been riddled with these identical error messages ever since 2.8.0 and continues in 2.8.1, sometimes several logged within a few seconds when ZDoom isn't even running. I'm curious as to what this could be caused by. I have tried clean installs from the main download page, and it should be noted that it it complains about neither GZDoom 2.1.1 nor 1.9.1. This causes me no inconvenience but a flooded event viewer, but I thought it'd be something worth bringing up.

System is Windows 7 Home Premium x64 with an FX-4100 processor.

Log data is as follows:

---

Code: Select all

Activation context generation failed for "C:\DOOM\ZDOOM\zdoom.exe".Error in manifest or policy file "" on line . A component version required by the application conflicts with another component version already active. Conflicting components are:. Component 1: C:\Windows\WinSxS\manifests\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.18837_none_41e855142bd5705d.manifest. Component 2: C:\Windows\WinSxS\manifests\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.18837_none_fa3b1e3d17594757.manifest.

Code: Select all

- System 
  - Provider 
   [ Name]  SideBySide 
  - EventID 80 
   [ Qualifiers]  49409 
   Level 2 
   Task 0 
   Keywords 0x80000000000000 
 
  - TimeCreated 
   [ SystemTime]  2016-02-26T04:52:00.000000000Z 
   EventRecordID 132365 
   Channel Application 
   Computer <edited>
   Security 
 

- EventData 
   C:\Windows\WinSxS\manifests\x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.18837_none_41e855142bd5705d.manifest 
   C:\Windows\WinSxS\manifests\amd64_microsoft.windows.common-controls_6595b64144ccf1df_6.0.7601.18837_none_fa3b1e3d17594757.manifest 

   C:\DOOM\ZDOOM\zdoom.exe 

[_mental_]

Official ZDoom binaries have two <assemblyIdentity> entries for Microsoft.Windows.Common-Controls in the manifest.
Although the corresponding file in the source code has only one.
It seems to be a problem of the build process.

[Medicris]

Thank you for the informative answer, I was hoping something wasn't bad on a system level. Hope it's all fixed soon!

[Graf Zahl]

This looks like some old stuff being cached somewhere and no clean being performed on the project. The change that caused this dates Jun 22, 2014. Apparently the manifest builder still got a reference to the old definition and copies both together.

To summarize, this can only be fixed in Randi's old compile setup (running a 'clean project' should be sufficient). The project itself is fine, and anything built from the master branch through CMake should also not suffer from that old, long disposed stuff.

[randi]

I always build the official releases from a newly-created directory, though.

[Graf Zahl]

I think I found it. The bogus entry comes from the file win32/zdoom.res which is part of the git repo. If that gets merged with the actual manifest you'll have both. Since the newer builds with VC2015 do not have this entry, they may not actually use that file to begin with. In fact, they create their own zdoom.res somewhere in the build directory.

[Graf Zahl]

So, this needs to be fixed in maint. In master it's no longer relevant, and all the VC2005 related files should be removed, actually, since they are no longer usable.

[_mental_]

Indeed, it's a good reason to remove Visual Studio files from the repository. CMake generated solution/projects work just fine for a long time.

[Graf Zahl]

Already done. And I removed the bogus zdoom.res file as well.
But the actual fix needs to be done in the maint branch and that I cannot test due to lack of proper compiler.

CMake generated solution/projects work just fine for a long time.

In fact, they have been working far BETTER than the native project ever since they have become usable. Not only do they not litter the temporary files throughout the project (one of the eternal mysteries of project management is, why is Microsoft literally FORCING such a shitty model on their users - the VS-auto-generated template projects are virtually useless because of it), they are also far easier to set up.

Oh, and they allowed me to dump the outdated VC2005 compiler on my last system reinstall.

[Graf Zahl]

I think this can be closed as the maint branch is too far behind without any chance of ever catching up because cherry picking the fixes is next to impossible considering how much the code has changed since then. The next release will have to be done from master.