Optional Doom v0.4 Style Move Bobbing

[Ryan Cordell]

I'll do one better than just submitting patches that might not work, here's an experimental build with the code in.
Weapon bob - Experimental build

An example of the code in use is:

Code: Select all

actor BobsPistol : replaces Pistol
{
  Game Doom
  Weapon.SelectionOrder 1900
  Weapon.AmmoUse 1
  Weapon.AmmoGive 20
  Weapon.AmmoType "Clip"
  Weapon.BobStyle "Alpha"
  Weapon.BobSpeed 100
  Weapon.BobLimit 8
  Obituary "oh gn0"
  +WEAPON.WIMPY_WEAPON
  Inventory.Pickupmessage "You got Bob's Pistol!"
  States
  {
  Ready:
    PISG A 1 A_WeaponReady
    Loop
  Deselect:
    PISG A 1 A_Lower
    Loop
  Select:
    PISG A 1 A_Raise
    Loop
  Fire:
    PISG A 4
    PISG B 6 A_FirePistol
    PISG C 4
    PISG B 5 A_ReFire
    Goto Ready
  Flash:
    PISF A 7 Bright A_Light1
    Goto LightDone
    PISF A 7 Bright A_Light0
    Goto LightDone
  Spawn:
    PIST A -1
    Stop
  }
}

let me know if there's any problems. I need suggestions/bugfixes before I can even think of submitting this fo' real.

[NeuralStunner]

Awesome! Didn't find a single thing wrong.

Test Mod - For best results, turn down MoveBob in your ZDoom settings.

Only suggestion I have is putting everything into a single Weapon.Bob property.

[Xaser]

Only suggestion I have is putting everything into a single Weapon.Bob property.

Why? That'd just serve to make things more confusing, if you mean something like 'Weapon.Bob "Alpha", 100, 8", because then you'd have to remember what those magic numbers mean.

[NeuralStunner]

That's what the Wiki is for? The only time I've had problems with "which property is which" is with [wiki=A_SpawnItemEx]mile-long action functions[/wiki].

[hfc2x]

Ryan's implementation is closer to Doom v0.5 than to v0.4, but it's still really good and would satisfy most people's needs, since most people seem to prefer setting things via DECORATE rather than menu options.

[Xaser]

Hmm, after trying the test wad, I have to say that this is pretty neat but could still benefit from a "BobLimit"-type variable for the y axis as well. The fact that you have to suggest that the user change one of their settings is a pretty clear indication that something's missing.

[NeuralStunner]

Hmm, after trying the test wad, I have to say that this is pretty neat but could still benefit from a "BobLimit"-type variable for the y axis as well.

I mentioned it to Ryan, he said he tried but it wasn't working well at all.

The fact that you have to suggest that the user change one of their settings is a pretty clear indication that something's missing.

No, just that I find the default view bob pretty nauseating, and it looks even stranger once you change how the weapon bobs. (Although I'd love to see a customized default viewbob for player classes.)

[Ryan Cordell]

I'd say I should give y-boblimit another go, although constrain the maximum to be the default value, so the weapon graphic doesn't look cut off.

[NeuralStunner]

Well, I think higher than default would be okay, it would be the modder's responsibility to provide sprites that compensate. (For example, alpha sprites go a whole 32 pixels below the baseline, and would work fine. Most sprites aren't made like this unfortunately.)

[Snarboo]

I have to agree, let the user decide what the maximum y-boblimit should be. If they don't change out the graphics to compensate for the sprite being cut off, that's their problem. :p

[WallyTheBoogieBug]

In addition to the Alpha-style bobbing option, there should be a toggle option that disables the camera bobbing up and down and only keeps the weapon sway. That way my accuracy will be as correct as possible at all times whilst keeping the idea that my character is moving around.