[r2351] Zen Dynamics inventory won't properly clear

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
edward850
Posts: 5890
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

[r2351] Zen Dynamics inventory won't properly clear

Post by edward850 »

It seems that something is preventing [wiki]ClearInventory[/wiki](); from doing its proper job, or at-least in Zen Dynamics where before your weapons where cleared properly (in map08 and map04), but instead, now some weapons are left behind (ignored). This never happened before (and is obviously not intended). When exactly, I'm unsure, but I have reason to believe the garbage collector is behind this issue.

I have attached a couple of save files which show this issue (saved in GZdoom [r811], but the bug is still on normal Zdoom [r2351]).
http://dl.dropbox.com/u/1150300/another ... /save2.zds
http://dl.dropbox.com/u/1150300/another ... save10.zds
(It seems I can't upload ZDS files. I'm sure you could before.)
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49234
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by Graf Zahl »

The garbage collector has absolutely nothing to do with it, that's for sure.
User avatar
ZDG
Posts: 918
Joined: Sat Jan 02, 2010 12:01 pm
Location: in SlumpEd

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by ZDG »

That's because inventory in ZD is using ACS and other hacky tricks, who can bug that command.
Gez
 
 
Posts: 17946
Joined: Fri Jul 06, 2007 3:22 pm

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by Gez »

edward850 wrote:(It seems I can't upload ZDS files. I'm sure you could before.)
Technically, they're PNG files with a funny extension, so you can always rename them.
User avatar
TheDarkArchon
Posts: 7656
Joined: Sat Aug 07, 2004 5:14 am
Location: Some cold place

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by TheDarkArchon »

ZDG wrote:That's because inventory in ZD is using ACS and other hacky tricks, who can bug that command.
...do you know what you're talking about? ACS usage is not a hacky trick. ACS usage should not cause any bugs with ClearInventory().
edward850 wrote:When exactly, I'm unsure, but I have reason to believe the garbage collector is behind this issue.
Like Graf said, this is wrong. Zen Dynamics worked for me after the garbage collector was implemented and still works for me as of GZDoom r797, which is based off ZDoom r2331

EDIT: Just tested with GZDoom r811 with Zen Dynamics, inventory clearing works fine.
User avatar
ZDG
Posts: 918
Joined: Sat Jan 02, 2010 12:01 pm
Location: in SlumpEd

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by ZDG »

I said Acs AND other Hacky tricks, like the Egosmasher reload.
User avatar
TheDarkArchon
Posts: 7656
Joined: Sat Aug 07, 2004 5:14 am
Location: Some cold place

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by TheDarkArchon »

ZDG wrote:I said Acs AND other Hacky tricks, like the Egosmasher reload.
Complexity != Hackiness.
User avatar
edward850
Posts: 5890
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by edward850 »

TheDarkArchon wrote:EDIT: Just tested with GZDoom r811 with Zen Dynamics, inventory clearing works fine.
Did you try the save files as well?
User avatar
TheDarkArchon
Posts: 7656
Joined: Sat Aug 07, 2004 5:14 am
Location: Some cold place

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by TheDarkArchon »

Bug happens in the saves, but I found that I was using an older* version on Zen when I was testing

*Possibly: The one currently in the archives has the TITLEMAP, which the older one I was using didn't have but used "replaces" instead of brute forcing the Doomednum for replacing the standard Doom stuff
User avatar
Xaser
 
 
Posts: 10774
Joined: Sun Jul 20, 2003 12:15 pm
Contact:

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by Xaser »

If it makes any difference whatsoever (read: it doesn't), this certainly didn't happen during testing way back when. :P

Out of curiosity, which weapons are refusing to be stripped? Not sure how much of the mystery it would solve, but it's worth a shot.
User avatar
edward850
Posts: 5890
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by edward850 »

It changes. Map08 it doesn't strip the Machete, Magnum, ZenSMG and Streetsweeper shotgun. Map04 its only the Machete and ZenSMG.
User avatar
randi
Site Admin
Posts: 7749
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by randi »

What version of Zen Dynamics? And what should I do to see this, since the saves are of no use now?
User avatar
edward850
Posts: 5890
Joined: Tue Jul 19, 2005 9:06 pm
Location: New Zealand
Contact:

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by edward850 »

This one appears to be the same version I have, based off the date.

Image
^^ And here is a save file. [r3404]^^
Just walk forwards, and a scripted sequence will attempt to take your weapons.

Side edit: Quite a gap between thread creation and now. Did you pull the thread-name out of a hat or something? :D
User avatar
randi
Site Admin
Posts: 7749
Joined: Wed Jul 09, 2003 10:30 pm
Contact:

Re: [r2351] Zen Dynamics inventory won't properly clear

Post by randi »

Fixed.

In answer to your question, I'm just trying to clear out the ones that come up when I search for "ACS" in the bugs forum.
Post Reply

Return to “Closed Bugs [GZDoom]”