r3180 compile error

[Enjay]

Code: Select all

2>music_mus_midiout.cpp
2>.\src\sound\music_mus_midiout.cpp(328) : error C2782: 'const T MIN(const T,const T)' : template parameter 'T' is ambiguous
2>        src\templates.h(159) : see declaration of 'MIN'
2>        could be 'int'
2>        or 'BYTE'

[Gez]

What was wrong with using if (mid2 & 0x80) mid2 = 0x7F; instead of this templated clamping?

[Edward-san]

Replacing "MIN(mid2, 0x7F))" with "MIN((int)mid2, 0x7F))" it lets compile for me.

[randi]

What was wrong with using if (mid2 & 0x80) mid2 = 0x7F; instead of this templated clamping?

You clamped the processed value rather than the original from the MUS file, so I had to move it and figured that would be the simplest thing to do.

[Enjay]

- Oh my goodness, maybe I need to try compiling things before committing them!

Well, it definitely compiles now.