ACS script isn't working properly.

[iSpook]

Giving this a shot on my own resulted in a bit of failure.

Code: Select all

#include "zcommon.acs"
script 1 open {
  if(GetActorProperty(0, APROP_HEALTH) <25)
  {
  Giveinventory(HealthBonus, 1);
  {
  Delay(36);
  restart;
  }

Could someone tell me what I did wrong, please? (For extra information, this is meant as a script that is supposed to Start as soon as the player enters the level.)

[Ceeb]

Code: Select all

script 1 enter

[Apothem]

When using a script that has open associated with it, the activator is the map. If you use ENTER, the activator is the player. For commands like giveinventory, you need to make sure the activator is the appropriate actor. In this case, it's the player.

[Ceeb]

When using a script that has open associated with it, the activator is the map. If you use ENTER, the activator is the player. For commands like giveinventory, you need to make sure the activator is the appropriate actor. In this case, it's the player.

Which is what I said. Very abbreviated.

[iSpook]

Alright, I just need a more help, the script doesn't activate for some reason. (I've deliberately damaged myself to 20-18 points, to see if it'll activate, and it doesn't Here's where i've tried to stick the Execute in the decorate.

Code: Select all

States
  {
  Spawn:
    PLAY A -1
    PLAY A 0 ACS_ExecuteAlways(1,0,0,0,0)
    Loop

I dunno if it's the Script itself ( I doubt it, but there's always a chance.), the way I set up the Command or if I'm doing this entirely wrong. (I am quite new at this.)

[Remmirath]

It won't never jump to the state with the ACS execute because you are using a -1 duration in the first state.

[iSpook]

Oh... It's always the most obvious mistakes, thanks.

[HotWax]

Um, if you used script 1 enter (as previously suggested), you should not need to activate the script manually. A copy of it should automatically start running for each player the moment they enter the map. So unless you're terminating it elsewhere, I don't see why it wasn't working for you previously.

Scratch that, yes I do. You've got a bracket flipped, and you've misused GiveInventory.

Code: Select all

script 1 enter
{
	if (GetActorProperty(0, APROP_Health) < 25)
	{
		GiveInventory("HealthBonus", 1); // Note the quotation marks
	} // Note the fixed bracket

	delay (36)
	restart;
}

Frankly I'm surprised your previous version compiled. (You did compile it, right?)

[iSpook]

Nope, I did not. I was working in a SCRIPT lump directly.

[Remmirath]

To make it working, you have to compile it.

[iSpook]

Oh, didn't think it was -required- to make it work, thought 'compile' was the equivalent to 'saving' it.

[Remmirath]

The compiling process transforms the text into a compiled lump called BEHAVIOR. That makes it readable for the engine.

[HotWax]

The compiling process transforms the text into a compiled lump called BEHAVIOR. That makes it readable for the engine.

Which is also convenient for error-checking, to make sure you've written a valid script.

[Remmirath]

That, too.

If syntax is incorrect, it simply won't compile the script.