[Decorate] Teleport glitter

[The Ultimate DooMer]

I was wondering about this: is it possible to recreate Heretic's teleport glitter in decorate without inheriting from it's states?

[Graf Zahl]

Not directly. The acceleration can't be recreated properly. Do you need more than 2 types?

[The Ultimate DooMer]

I'm trying to make one that is solid, but one that disappears after a certain time.

[Graf Zahl]

You can experiment with ThrustThingZ to accelerate the glitter. It won't look exactly the same but that doesn't probably matter, does it?

[The Ultimate DooMer]

I was hoping to preserve the Heretic effect (which looked sorta 3D) but it looks like I'm gonna have to create a normal 2D sprite instead :/

[Hirogen2]

Well Heretic's one looks 3D because it uses like 3 or 4 glitters (=things) per teleporter, I would not see any problem with scripting that the four glitters rise asynchronically.

[Graf Zahl]

Actually, it doesn't. The generator just spawns the glitter at random positions:

Code: Select all

void A_SpawnTeleGlitter (AActor *actor)
{
	AActor *mo;
	fixed_t x = actor->x+((pr_teleg()&31)-16)*FRACUNIT;
	fixed_t y = actor->y+((pr_teleg()&31)-16)*FRACUNIT;

	mo = Spawn<ATeleGlitter1> (x, y,
		actor->Sector->floorplane.ZatPoint (actor->x, actor->y));
	mo->momz = FRACUNIT/4;
}

[Bio Hazard]

Iyaa! That can be simplified!

Code: Select all

void A_SpawnTeleGlitter(AActor *actor){
	AActor *mo = Spawn<ATeleGlitter1>(
		(actor->x+((pr_teleg()&31)-16)*FRACUNIT),
		(actor->y+((pr_teleg()&31)-16)*FRACUNIT),
		actor->Sector->floorplane.ZatPoint(actor->x,actor->y)
	);
	mo->momz = FRACUNIT/4;
}

Saves sizeof(fixed_t)*2 bytes!

[Graf Zahl]

The original code doesn't create any stack variables. It holds both in a register - and is more readable. There's no need to killoughize this code to the point of unreadability. Compilers have optimizers for a good reason.

And what's the point in saving stack anyway?

[The Ultimate DooMer]

I created a 2D column instead but at least I got the feature working.

[Hirogen2]

Iyaa! That can be simplified!

Code: Select all

void A_SpawnTeleGlitter(AActor *actor){
	AActor *mo = Spawn<ATeleGlitter1>(
		(actor->x+((pr_teleg()&31)-16)*FRACUNIT),
		(actor->y+((pr_teleg()&31)-16)*FRACUNIT),
		actor->Sector->floorplane.ZatPoint(actor->x,actor->y)
	);
	mo->momz = FRACUNIT/4;
}

Saves sizeof(fixed_t)*2 bytes!

This can, I think, be crushed even more, of course sacrificing readabilitz:

Code: Select all

	Spawn<ATeleGlitter1>(
		(actor->x+((pr_teleg()&31)-16)*FRACUNIT),
		(actor->y+((pr_teleg()&31)-16)*FRACUNIT),
		actor->Sector->floorplane.ZatPoint(actor->x,actor->y)
	)->momz = FRACUNIT/4;

Saving even the 'mo' variable...

And what's the point in saving stack anyway?

Ask the Linux kernel people on why they try to enforce "4K stacks" instead of larger ones (8K).

[Graf Zahl]

But still saving no stack at all. The compiler needs the same amount of registers for all versions.

[Bio Hazard]

Maybe it's just me but I find it more readable when everything is crushed. Less stuff to keep track of.

[Graf Zahl]

I find it more readable when it is structured. Less stuff to keep track of at the same time!

[Doomguy0505]

Why don't you use sprites instead