[help] trying to make friendlies not harm player/s

[orosa]

Hey all, newbie question here, recently I downloaded something from the 667 repository site, The "beacon" file.

Anyway, it spawns in marines that basically walk and shot. Nothing crazy. But I've been trying to modify it to make it not harm the player, for a little while now, and I have had no luck in doing so. Basically, what I am asking is what am I missing/doing wrong. here is my code for 2 different marines.

Code: Select all

ACTOR MarineShotgunFriend : MarineShotgun
{
	Health 500
	MONSTER
	+MISSILEEVENMORE
	+NORADIUSDMG
	+QUICKTORETALIATE
	+FLOORCLIP
	+FRIENDLY
	
	+THRUSPECIES
	+MTHRUSPECIES
	+ALLOWTHRUFLAGS
		
	+NODAMAGE
	+DONTHARMCLASS
	Species "doomplayer"
	DropItem "NewShotgun"
	States
   {
   Spawn:
      PLAY ABCD 5 A_Wander
	  PLAY ABCD 0 A_Look
      Loop
	}
}

Code: Select all

ACTOR MarineRocketFriend : MarineRocket
{
	Health 500
	MONSTER
	+MISSILEEVENMORE
	+NORADIUSDMG
	+QUICKTORETALIATE
	+FLOORCLIP
	+FRIENDLY
	
	+THRUSPECIES
	+MTHRUSPECIES
	+ALLOWTHRUFLAGS
		
	+NODAMAGE
	+DONTHARMCLASS
	Species "doomplayer"	
	
	DropItem "NewRL"
	States
   {
   Spawn:
      PLAY ABCD 5 A_Wander
	  PLAY ABCD 0 A_Look
      Loop
	}
}

and knowing me it probably one flag that I miss..... or I am going about this very very wrong.

[Cherno]

I don't think it can be done this easily in DECORATE. You could give the Marines attacks with a DamageType for which the Player has a DamageFactor of 0. In zScript, you could simply override DamageMobj and check of the source of the attack has the FRIENDLY flag set to true.

[orosa]

I fiddled around with this for a few days and had no luck. Thanks for the help anyway Cherno. But I think I am going to leave it as is.

[Caligari87]

Could cast a non-damaging lineattack and see if the puff returns a player, and if so abort the attack sequence. would be easier in zscript but possible with some hackery in DECORATE.

[orosa]

i will have a look into line attack, in the meantime how would I go about it in zscript?

[Cherno]

You'd need a zScript PlayerPawn. gzdoom.pk3 has zScript versions of all playerclasses. Check the wiki to use custom playerclasses and how to load zScript files.
https://zdoom.org/wiki/ZScript
https://zdoom.org/wiki/Creating_new_player_classes
Join the Discord if you need help

Add this to the Player class:

Code: Select all

	override int DamageMobj(Actor inflictor, Actor source, int damage, Name mod, int flags, double angle)
	{
               if(source != null && source.bFRIENDLY)
                {
                     return Super.DamageMobj(inflictor,source,0,mod,flags,angle);
                }
		return Super.DamageMobj(inflictor,source,damage,mod,flags,angle);
	}

[Caligari87]

Two clarify, there's two separate approaches being discussed here.

1. Skip damaging the player if a friendly attack hits the player
2. prevent the monster from attacking if the player is in the way (my suggestion)

Here's some (untested!) code for how I'd implement #2

Code: Select all

class FriendlySmartImp : DoomImp {
	default {
		+Friendly;
	}
	
	states {
		missile:
			TROO EF 8 A_FaceTarget(0, 0, 0, 0, FAF_MIDDLE);
			TROO G 3 A_TargetCheck;
			TROO G 3 A_TroopAttack;
			Goto See;
		skipmissile:
			TROO FE 6;
			goto See;
	}
	
	action state A_TargetCheck() {
		FLineTraceData tracedata
		linetrace(angle, 1024, pitch, offsetz: height/2, data: tracedata);
		if (tracedata.hitactor is playerpawn) { return ResolveState("skipmissile");
		return null;
	}
}

In short, a custom action function that sends a line trace from the imp's angle/pitch and checks if it hits a playerpawn, then if so jumps to a cancellation state, otherwise the attack continues normally.

[Apeirogon]

Did you try to set player pawn species to "doomplayer"?
Because IIRC by default its "none".

[Caligari87]

This checks player class hierarchy, not species.

[orosa]

sorry for the late response, I been working on this for quite a while now, and I still not getting anywhere I might come back to this in a few weeks and try again with a more fresh mind sorry for bugging everyone.