[4.2.4] Dynamic Lights not unloading

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

[4.2.4] Dynamic Lights not unloading

Post by sinisterseed »

Looks like the dynamic lights don't always get unloaded when unchecking their box at startup.

I just ran into this with nomono.wad (No Monochrome). I played cursed01.wad before it with both brightmaps and dynamic lights, and unloaded them when I moved to No Monochrome (but didn't turn off the Hardware option in the game). Once I got into the game, I noticed some things still had dynamic lights working. I turned off the Hardware option afterwards and they disappeared - and didn't reappear when I re-enabled it without checking the box of the dynamic lights.

Some steps to reproduce this would be:

1) Download cursed01.wad (Cursed Realms - Path Over the Abyss).
2) Check the boxes of both brightmaps and dynamic lights on startup.
3) Start the game and then close it. Leave Dynamic Lights (Hardware) turned on in the options.
4) Move to nomono.wad (No Monochrome). On startup, uncheck both boxes.
5) Once in game, look for things such as some red lights in the outdoor area where you first pick up a Berserk. They should be still emitting light.
6) Turn the Hardware option off now and then re-enable it. The lights should not reappear once the option is re-enabled.

I didn't post this into the OpenGL subforum because I'm not sure whether this happens with any of the SW renders or not. May, or may not be specific only to OpenGL.
Jarewill
 
 
Posts: 1855
Joined: Sun Jul 21, 2019 8:54 am

Re: [4.2.4] Dynamic Lights not unloading

Post by Jarewill »

That's normal.
Your save's mod configuration got saved with it, so when you tried loading it, it loaded the dynamic lights with it.
If I recall correctly all you need to do is beat a level and it should return to normal.

Edit: I think I might have misread what you meant, but I will leave the post just in case.
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.2.4] Dynamic Lights not unloading

Post by sinisterseed »

It definitely shouldn't be normal since I unloaded them at startup but they got loaded anyway...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49252
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.2.4] Dynamic Lights not unloading

Post by Graf Zahl »

A quick note here: a bug report without a link to the mod is a perfect scenario for stuff to be forgotten. Having to hunt for downloads means that it will most likely be skipped over each time somebody looks at it.
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.2.4] Dynamic Lights not unloading

Post by sinisterseed »

User avatar
phantombeta
Posts: 2184
Joined: Thu May 02, 2013 1:27 am
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia with Vulkan support
Location: Brazil

Re: [4.2.4] Dynamic Lights not unloading

Post by phantombeta »

The checkbox isn't broken. It doesn't enable dynamic lights, it simply enables automatic loading of the actor lights addon that comes with GZDoom. Map-placed dynamic lights will still work because they don't require said addon and aren't supposed to.
User avatar
sinisterseed
Posts: 1349
Joined: Tue Nov 05, 2019 6:48 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.2.4] Dynamic Lights not unloading

Post by sinisterseed »

phantombeta wrote:The checkbox isn't broken. It doesn't enable dynamic lights, it simply enables automatic loading of the actor lights addon that comes with GZDoom. Map-placed dynamic lights will still work because they don't require said addon and aren't supposed to.
That still doesn't explain what I'm reporting here though. Or I'm just dumb and missing the point, that's also a possibility.
_mental_
 
 
Posts: 3820
Joined: Sun Aug 07, 2011 4:32 am

Re: [4.2.4] Dynamic Lights not unloading

Post by _mental_ »

lowskill. wrote:6) Turn the Hardware option off now and then re-enable it. The lights should not reappear once the option is re-enabled.
Exit the menu, and lights will reappear again. Because of implementation details, dynamic lights require one game tick to be activated.
Post Reply

Return to “Closed Bugs [GZDoom]”