[2.7.0+] Thing_Destroy from DECORATE is broken

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [2.7.0+] Thing_Destroy from DECORATE is broken

Re: [2.7.0+] Thing_Destroy from DECORATE is broken

by Graf Zahl » Tue Jan 21, 2014 11:38 am

Ok, in that case it gets filed as 'not a bug'. The special case where a projectile needs to remain shootable after impact can easily be handled by setting the SHOOTABLE flag via code pointer again.

Re: [2.7.0+] Thing_Destroy from DECORATE is broken

by Blue Shadow » Tue Jan 21, 2014 11:32 am

I did some searching, and found this.

Re: [2.7.0+] Thing_Destroy from DECORATE is broken

by Blzut3 » Tue Jan 21, 2014 11:18 am

This is the cause. Now the question is why was that change needed and is there anything we can do about it?

Re: [2.7.0+] Thing_Destroy from DECORATE is broken

by Gez » Tue Jan 21, 2014 10:41 am

Re: [2.7.0+] Thing_Destroy from DECORATE is broken

by Blue Shadow » Tue Jan 21, 2014 10:37 am

Yeah, I should've investigated the code more carefully before posting the bug report; the projectile setup is indeed a weird one. To my defense, I went with the assumption that the weapon worked for the author when he/she wrote its code 4 or 5 years ago with whatever ZDoom version it was tested on back then. And now it doesn't work anymore.

Still, I'm curious as to why it worked back then and now it doesn't.


(I think you can close this bug report. I or someone else will have to find way to fix that code and submit an updated version of it to Realm667)

Re: [2.7.0+] Thing_Destroy from DECORATE is broken

by Graf Zahl » Tue Jan 21, 2014 8:22 am

Are you sure it's Thing_Destroy and not rather the messy way your death state tries to assign a Tid?
That one's just 'ugh'...

[2.7.0+] Thing_Destroy from DECORATE is broken

by Blue Shadow » Tue Jan 21, 2014 5:18 am

Calling [wiki]Thing_Destroy[/wiki] from DECORATE doesn't appear to work (at least not with the case the I've got here) starting with ZDoom 2.7.0 onwards. 2.6.1 was the last official release this worked on.

In the linked file below, is a weapon that fires "sticky" projectiles with the primary fire key, and detonates said projectiles with the secondary fire key. The detonation code uses Thing_Destroy to do so. Here is the code:
Spoiler:
And here is the file: http://www.realm667.com/index.php/repos ... doom-style (Before running it, you need to extract it first, as it's a pk3 inside a zip)

Top