[2.7.0+] Thing_Destroy from DECORATE is broken

[Blue Shadow]

Calling [wiki]Thing_Destroy[/wiki] from DECORATE doesn't appear to work (at least not with the case the I've got here) starting with ZDoom 2.7.0 onwards. 2.6.1 was the last official release this worked on.

In the linked file below, is a weapon that fires "sticky" projectiles with the primary fire key, and detonates said projectiles with the secondary fire key. The detonation code uses Thing_Destroy to do so. Here is the code:

---

Code: Select all

// --------------------------------------------------------------------------
//
// Bio Pipebomb Launcher, sprites from Xaser's p0wer_x.wad
//
// --------------------------------------------------------------------------

Actor BioPipebombLauncher : Weapon
{
	Weapon.Kickback 100
	Weapon.AmmoUse 1
	Weapon.AmmoGive 12
	Weapon.AmmoType "BioContainer"
	Inventory.PickupMessage "Bio Pipebomb Launcher!"
	Weapon.UpSound "Weapons/BioReady"
	States
	{
	Spawn:
		BPBL M -1
		Loop
	Ready:
		BPBL ABCD 5 A_WeaponReady
		Loop
	Deselect:
		BPBL A 1 A_Lower
		Loop
	Select:
		BPBL A 1 A_Raise
		Loop
	Fire:
		TNT1 A 0 A_GunFlash
		TNT1 A 0 A_PlaySoundEx("Weapons/BioFire","Weapon")
		BPBL E 7 A_FireCustomMissile("BioProj")
		BPBL F 8
		BPBL G 7
		BPBL H 8
		Goto Ready
	Flash:
		BPBL I 2 A_Light(2)
		BPBL J 2
		BPBL K 2
		BPBL L 2
		Stop
	AltFire:
		BPBL A 2 Thing_Destroy(2648) //Sets off projectiles.
		BPBL B 2
		BPBL C 2
		BPBL D 2
		Goto Ready
	}
}

// --------------------------------------------------------------------------
//
// Bio Proj, sprites from Captain Toenail and Daniel's NeoDoom.wad
//
// --------------------------------------------------------------------------

Actor BioProj
{
	Radius 5
	Height 5
	RenderStyle Translucent
	Alpha .7
	Decal "BioDecal"
	Speed 30
	DamageType Poison
	Projectile
	+Shootable //So alt fire works.
	+DontSplash
	+SeekerMissile //So A_Fire works.
	+ForceRadiusDmg
	+DontFall //Stops it from falling after sticking to targets.
	States
	{
	Spawn:
		BPBP ABC 3 Bright A_SpawnItemEx("BioPuff",0,0,0,0,0,0,0,128)
		Loop
		TNT1 A 0 A_Stop
		TNT1 A 0 Thing_ChangeTID(0,2648)
		BPBP AAABBBCCC 1 Bright A_Fire(35)
		Goto Spawn+5
	Death:
		TNT1 A 0 A_JumpIf(tid == 2648,1)
		Goto Spawn+3
		TNT1 A 0 A_PlaySoundEx("Weapons/BioProj","Weapons")
		TNT1 A 0 A_Explode(100,192)
		TNT1 A 0 A_SpawnItemEx("BioPuff",0,0,0,0,0,0,0,128)
		BPBP DEF 6 Bright
		Stop
	XDeath:
		TNT1 A 0 A_Stop
		Goto Spawn+4
	}
}

// --------------------------------------------------------------------------
//
// Bio Puff, sprites from Raven Software
//
// --------------------------------------------------------------------------

Actor BioPuff
{
	Radius 0
	Height 0
	+NoBlockMap
	+NoGravity
	+Randomize
	+PuffOnActors
	RenderStyle Translucent
	Scale .5
	Alpha .25
	VSpeed 1
	Mass 5
	States
	{
	Spawn:
		BPBP GHIJKLMIHG 2 Bright
		Stop
	}
}

// --------------------------------------------------------------------------
//
// Bio Pipebomb Launcher ammo, sprites from Daniel's ARSENAL.WAD
//
// --------------------------------------------------------------------------

Actor BioContainer : Ammo
{
	Inventory.Amount 6
	Inventory.MaxAmount 60
	Ammo.BackpackAmount 12
	Ammo.BackpackMaxAmount 120
	Inventory.PickupMessage "Bio Container"
	Inventory.Icon BIOCA0
	States
	{
	Spawn:
		BIOC A -1
		Loop
	}
}

Actor BioContainerHefty : BioContainer
{
	Inventory.Amount 30
	Inventory.PickupMessage "Bio Container Hefty"
	States
	{
	Spawn:
		BIOC B -1
		Stop
	}
}

And here is the file: http://www.realm667.com/index.php/repos ... doom-style (Before running it, you need to extract it first, as it's a pk3 inside a zip)

[Graf Zahl]

Are you sure it's Thing_Destroy and not rather the messy way your death state tries to assign a Tid?
That one's just 'ugh'...

[Blue Shadow]

Yeah, I should've investigated the code more carefully before posting the bug report; the projectile setup is indeed a weird one. To my defense, I went with the assumption that the weapon worked for the author when he/she wrote its code 4 or 5 years ago with whatever ZDoom version it was tested on back then. And now it doesn't work anymore.

Still, I'm curious as to why it worked back then and now it doesn't.


(I think you can close this bug report. I or someone else will have to find way to fix that code and submit an updated version of it to Realm667)

[Gez]

For reference: http://www.realm667.com/board/viewtopic.php?f=7&t=5928

[Blzut3]

This is the cause. Now the question is why was that change needed and is there anything we can do about it?

[Blue Shadow]

I did some searching, and found this.

[Graf Zahl]

Ok, in that case it gets filed as 'not a bug'. The special case where a projectile needs to remain shootable after impact can easily be handled by setting the SHOOTABLE flag via code pointer again.