r3180 compile error

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: r3180 compile error

Re: r3180 compile error

by Enjay » Thu Apr 14, 2011 4:00 pm

Changelog wrote:- Oh my goodness, maybe I need to try compiling things before committing them!
:lol:

Well, it definitely compiles now. :)

Re: r3180 compile error

by randi » Thu Apr 14, 2011 3:50 pm

Gez wrote:What was wrong with using if (mid2 & 0x80) mid2 = 0x7F; instead of this templated clamping?
You clamped the processed value rather than the original from the MUS file, so I had to move it and figured that would be the simplest thing to do.

Re: r3180 compile error

by Edward-san » Thu Apr 14, 2011 3:18 pm

Replacing "MIN(mid2, 0x7F))" with "MIN((int)mid2, 0x7F))" it lets compile for me.

Re: r3180 compile error

by Gez » Thu Apr 14, 2011 2:26 pm

What was wrong with using if (mid2 & 0x80) mid2 = 0x7F; instead of this templated clamping?

r3180 compile error

by Enjay » Thu Apr 14, 2011 2:13 pm

Code: Select all

2>music_mus_midiout.cpp
2>.\src\sound\music_mus_midiout.cpp(328) : error C2782: 'const T MIN(const T,const T)' : template parameter 'T' is ambiguous
2>        src\templates.h(159) : see declaration of 'MIN'
2>        could be 'int'
2>        or 'BYTE'

Top