Strange portal rendering glitch (since maybe 4.8)

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Strange portal rendering glitch (since maybe 4.8)

Re: Strange portal rendering glitch (since maybe 4.8)

by emile_b » Mon Jul 25, 2022 12:04 pm

Ah just seen, good fix :thumb:

Re: Strange portal rendering glitch (since maybe 4.8)

by Graf Zahl » Thu Jul 14, 2022 2:40 am

I rewrote that part to use safe language constructs instead. If this broke once it may do so again in the future on a different system so better let's steer clear of such unsafe type punning exploits.

Re: Strange portal rendering glitch (since maybe 4.8)

by Graf Zahl » Thu Jul 14, 2022 2:20 am

It's an alignment issue. Some recent change added an internal virtual method table pointer to this struct and with 32 bit alignment rules causes the part that mimics line_t to not align to 8 bytes anymore - but then fails with aligning the DVector2, creating an alignment gap, which is critical.

Re: Strange portal rendering glitch (since maybe 4.8)

by emile_b » Tue Jul 05, 2022 1:30 pm

Lol oh yeah sorry, it was something I found ages ago, didn't realise it was in upstream. Maybe it needs to be removed?! On ARM it seems to cause exactly the same error as shown in the picture and only affects 32bit code. But maybe not related, sorry for the false alarm!

Edit: yeah seems to I have snuck in with the gles2 updates last year

Re: Strange portal rendering glitch (since maybe 4.8)

by Rachael » Tue Jul 05, 2022 1:11 pm

If that's the case it could be a compiler error. If one simple line is enough to fix this, I will add it, but with the caveat that this does not change GZDoom's official status for supporting 32-bit. If anyone wants to do a 32-bit fork and this helps them, though - I have no issue with that. :)

EDIT: This already seems to be in GZDoom's master branch?

Re: Strange portal rendering glitch (since maybe 4.8)

by emile_b » Tue Jul 05, 2022 10:22 am

I know this is closed but for interest this is cause by some alignment issue between HWLinePortal and line_t

This is the fix for 32bit machines for me:
https://github.com/emileb/gzdoom/blob/1 ... tal.h#L161

I can't see what exactly is causing it as the code looks like it should work fine. Thought I would mention it in case there is something fragile in the code and this appears later even on 64bit machines.

Re: Strange portal rendering glitch (since maybe 4.8)

by drfrag » Tue Jul 05, 2022 4:07 am

Most likely it's an old VS 2019 bug (or something changed in the compiler), same thing happened with mirrors and they worked when compiled with VS 2017. No longer relevant of course.

Re: Strange portal rendering glitch (since maybe 4.8)

by Hirogen2 » Tue Jul 05, 2022 2:55 am

Data point: Using an -m32 build on a x64 CPU,

Code: Select all

GZDoom 4.8.1 -  - SDL version
...
CPU Vendor ID: GenuineIntel
  Name: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
  Family 6, Model 140, Stepping 1
  Features: SSE2 SSE3 SSSE3 SSE4.1 SSE4.2 AVX AVX2 AVX512 F16C FMA3 BMI1 BMI2 HyperThreading
Using video driver x11
GL_VENDOR: Intel
GL_RENDERER: Mesa Intel(R) Xe Graphics (TGL GT2)
GL_VERSION: 4.6 (Core Profile) Mesa 22.1.2 (Core profile)
GL_SHADING_LANGUAGE_VERSION: 4.60
The demo portal map shows no issue for me.

Re: Strange portal rendering glitch (since maybe 4.8)

by Blzut3 » Thu Jun 23, 2022 12:14 am

As a reminder if you guys want a change in the build process all you need to do is drop a message my way (or a pull request). I don't read every thread on this forum, but happened to browse this one today.

Re: Strange portal rendering glitch (since maybe 4.8)

by Graf Zahl » Wed Jun 22, 2022 3:07 am

Yes, they should be stopped.

I think I just add a static_assert to make them fail for now.

Re: Strange portal rendering glitch (since maybe 4.8)

by Nash » Wed Jun 22, 2022 2:54 am

Blue Shadow wrote:People are getting them from here :p
Hmm, I wonder if it's better to stop building them. I don't see the point, if the official stance on 32 bit is that it's no longer supported.

Re: Strange portal rendering glitch (since maybe 4.8)

by Blue Shadow » Wed Jun 22, 2022 2:53 am

People are getting them from here :p

Re: Strange portal rendering glitch (since maybe 4.8)

by Graf Zahl » Wed Jun 22, 2022 1:23 am

Self-compiled, presumably..

But let's make this clear: 32 bit isn't being tested anymore and no guarantees are given, and any 32 bit specific bug report will be closed on sight.

Re: Strange portal rendering glitch (since maybe 4.8)

by Nash » Wed Jun 22, 2022 12:19 am

Where are these 32 bit executables even being downloaded/distributed? The main site clearly only offers a 64 bit download...

Re: Strange portal rendering glitch (since maybe 4.8)

by Graf Zahl » Tue Jun 21, 2022 4:27 pm

In that case, case closed.
32 Bit is not supported anymore.

Top