SLADE Discussion - Latest: v3.2.7 (25/Dec/2024)

[disposable_username2]

I'm not really surprised that this file in particular would cause problems, since it was pretty much what it was designed to do.

Can this be fixed?

[Tapwave]

I'm not really surprised that this file in particular would cause problems, since it was pretty much what it was designed to do.

Can this be fixed?

Why would you want a fix for a file that was supposed to be utterly useless and unusable?

[Gez]

Can this be fixed?

That's what I'm looking into. Thanks for making me download a 1-gb Terrywad, by the way.

[NeuralStunner]

1-gb Terrywad

New taunts! Alriiiiiight!

[Gez]

So far, I've found one issue that can't be fixed: opening infebase.zip (the 1.2 mb file containing the huge one) provokes an unhandled exception right inside a wxWidgets function (wxZipInputSteam::Read(), if you're curious) and so as long as we're using wx code to handle zips, that's just one other limitation we'll have to live with.

And guess what, the second half of the problem, if trying to open an extracted infebase.pk3 directly, happens in... wxFile::Read().

[disposable_username2]

And guess what, the second half of the problem, if trying to open an extracted infebase.pk3 directly, happens in... wxFile::Read().

Hm. Does this mean that programs that use wxWidgets can't open big files? That'd be a serious bug... If you report it, maybe they'll fix it.

[cq75]

Is there another function to open larger files?

If not, the developers may have intended for the read() method to work with any size of file, and it's possible that a recent change has broken the function without their knowledge.

[Edward-san]

Hi, I've taken the initiative and made a code analysis check with cppcheck.

The results are saved in the file I'll attach here.

Can you do me a favor and report in a different file the false positive ones (with, if possible, a detailed explanation)? I don't have the time to analyze it and also I don't know a lot about the code.

sladecpchkresults.txt

It took a lot less time, against zdoom (that one took almost 3 days with my laptop active day and night). WTH?

(31.76 KiB) Downloaded 42 times

[riderr3]

r.1021 is crashed when opening any map

code

---

Code: Select all

Version: 3.0.2
Stack Trace:
0: ()
1: strtod()
2: ()
3: gluBuild2DMipmaps()
4: GLTexture::loadData(unsigned char const*, unsigned int, unsigned int, bool)()
5: GLTexture::loadImage(SImage*, Palette8bit*)()
6: MapTextureManager::MapTextureManager(Archive*)()
7: MapEditorWindow::MapEditorWindow()()
8: ArchiveManagerPanel::onListMapsActivated(wxListEvent&)()
9: wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const()
10: wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const()
11: wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)()
12: wxEvtHandler::SearchDynamicEventTable(wxEvent&)()
13: wxEvtHandler::TryHereOnly(wxEvent&)()
14: wxEvtHandler::ProcessEventLocally(wxEvent&)()
15: wxEvtHandler::ProcessEvent(wxEvent&)()
16: wxScrollHelperEvtHandler::ProcessEvent(wxEvent&)()
17: ()
18: ()
19: wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const()
20: wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const()
21: wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)()
22: wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)()
23: wxEvtHandler::TryHereOnly(wxEvent&)()
24: wxEvtHandler::ProcessEventLocally(wxEvent&)()
25: wxEvtHandler::ProcessEvent(wxEvent&)()
26: wxEvtHandler::SafelyProcessEvent(wxEvent&)()
27: wxWindowBase::HandleWindowEvent(wxEvent&) const()
28: wxWindow::GTKProcessEvent(wxEvent&) const()
29: ()
30: ()
31: g_closure_invoke()
32: ()
33: g_signal_emit_valist()
34: g_signal_emit()
35: ()
36: gtk_propagate_event()
37: gtk_main_do_event()
38: ()
39: g_main_context_dispatch()
40: ()
41: g_main_loop_run()
42: gtk_main()
43: wxGUIEventLoop::Run()()
44: wxAppConsoleBase::MainLoop()()
45: wxAppConsoleBase::OnRun()()
46: wxAppBase::OnRun()()

[sirjuddington]

Hi, I've taken the initiative and made a code analysis check with cppcheck.

The results are saved in the file I'll attach here.

Can you do me a favor and report in a different file the false positive ones (with, if possible, a detailed explanation)? I don't have the time to analyze it and also I don't know a lot about the code.

sladecpchkresults.txt

Heh, not sure I have time to go through all of that, but I looked at the memory leaks at least, and while most of them were very rare cases not really worth fixing (leaking memory when the function bombs out due to an error), a couple of them were legit (namely the ones in the doom format gfx loaders).

r.1021 is crashed when opening any map

code

---

Code: Select all

Version: 3.0.2
Stack Trace:
0: ()
1: strtod()
2: ()
3: gluBuild2DMipmaps()
4: GLTexture::loadData(unsigned char const*, unsigned int, unsigned int, bool)()
5: GLTexture::loadImage(SImage*, Palette8bit*)()
6: MapTextureManager::MapTextureManager(Archive*)()
7: MapEditorWindow::MapEditorWindow()()
8: ArchiveManagerPanel::onListMapsActivated(wxListEvent&)()
9: wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const()
10: wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const()
11: wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)()
12: wxEvtHandler::SearchDynamicEventTable(wxEvent&)()
13: wxEvtHandler::TryHereOnly(wxEvent&)()
14: wxEvtHandler::ProcessEventLocally(wxEvent&)()
15: wxEvtHandler::ProcessEvent(wxEvent&)()
16: wxScrollHelperEvtHandler::ProcessEvent(wxEvent&)()
17: ()
18: ()
19: wxAppConsoleBase::HandleEvent(wxEvtHandler*, void (wxEvtHandler::*)(wxEvent&), wxEvent&) const()
20: wxAppConsoleBase::CallEventHandler(wxEvtHandler*, wxEventFunctor&, wxEvent&) const()
21: wxEvtHandler::ProcessEventIfMatchesId(wxEventTableEntryBase const&, wxEvtHandler*, wxEvent&)()
22: wxEventHashTable::HandleEvent(wxEvent&, wxEvtHandler*)()
23: wxEvtHandler::TryHereOnly(wxEvent&)()
24: wxEvtHandler::ProcessEventLocally(wxEvent&)()
25: wxEvtHandler::ProcessEvent(wxEvent&)()
26: wxEvtHandler::SafelyProcessEvent(wxEvent&)()
27: wxWindowBase::HandleWindowEvent(wxEvent&) const()
28: wxWindow::GTKProcessEvent(wxEvent&) const()
29: ()
30: ()
31: g_closure_invoke()
32: ()
33: g_signal_emit_valist()
34: g_signal_emit()
35: ()
36: gtk_propagate_event()
37: gtk_main_do_event()
38: ()
39: g_main_context_dispatch()
40: ()
41: g_main_loop_run()
42: gtk_main()
43: wxGUIEventLoop::Run()()
44: wxAppConsoleBase::MainLoop()()
45: wxAppConsoleBase::OnRun()()
46: wxAppBase::OnRun()()

Hmm, I'm not 100% sure what is causing that, but try r1022, I changed something that might fix it.

[sirjuddington]

Here's a couple more WIP shots of the map editor (just to show that it's still coming along slowly). Been working on things mode stuff lately.

http://slade.mancubus.net/dev/3/s3me_ui4.png: Basic things mode view
http://slade.mancubus.net/dev/3/s3me_ui5.png: 'Show things as sprites' option from previous versions of SLADE is back (something I miss when using db2, sometimes)

[riderr3]

Great
What's with future plans of editor 3D mode? Can it use OpenGL or software renderer? SLADE2 has good 3D mode long time ago

[disposable_username2]

http://slade.mancubus.net/dev/3/s3me_ui5.png: 'Show things as sprites' option from previous versions of SLADE is back (something I miss when using db2, sometimes)

I see that selected things are encircled? It doesn't allow to see whether they are stuck in the wall I hope that there would be an option to show their bounding boxes instead (as in Slade2)

[sirjuddington]

Great
What's with future plans of editor 3D mode? Can it use OpenGL or software renderer? SLADE2 has good 3D mode long time ago

It'll likely be pretty similar to the SLADE2 3d mode, with some of the DB2 features I find nice, and a few extra I've thought of. No software renderer though, that would be a bit too difficult to implement. Unless someone else wants to

http://slade.mancubus.net/dev/3/s3me_ui5.png: 'Show things as sprites' option from previous versions of SLADE is back (something I miss when using db2, sometimes)

I see that selected things are encircled? It doesn't allow to see whether they are stuck in the wall I hope that there would be an option to show their bounding boxes instead (as in Slade2)

Yeah I can see your point. I just added a cvar to show things as squares instead, which serves this purpose and as a 'low detail' mode.

[Syfo-Dyas]

Is Slade designed for modern source ports with Hi-Res Textures and what not, or can it be used as a WinTex replacement for use with Vanilla DOOM, BOOM, and the like?