by Jekyll Grim Payne » Thu Dec 16, 2021 8:27 am
Currently A_CustomRailgun includes a pretty silly oversight where it *always* forces vertical aiming, even if the aim argument is 0:
Code: Select all
self->Angles.Pitch = P_AimLineAttack (self, self->Angles.Yaw, MISSILERANGE, &t, 60., 0, aim ? self->target : NULL);
Moreover, if you do
target = null, A_CustomRailgun doesn't produce any rails
at all.
That makes it impossible to actually use it as a utility function that simply performs a linear attack. Yes, I know that can be performed manually via LineTrace and such, but A_CustomRailGun can be convenient under some circumstances, and the way the aim currently works makes no sense.
Suggestion: add either aim 3, or a flag (something like RGF_IGNORETARGET or RGF_DONTFORCEAIM) that disables all kinds of aiming completely.
Currently A_CustomRailgun includes a pretty silly oversight where it *always* forces vertical aiming, even if the aim argument is 0:
[code]self->Angles.Pitch = P_AimLineAttack (self, self->Angles.Yaw, MISSILERANGE, &t, 60., 0, aim ? self->target : NULL);[/code]
Moreover, if you do [b]target = null[/b], A_CustomRailgun doesn't produce any rails [i]at all[/i].
That makes it impossible to actually use it as a utility function that simply performs a linear attack. Yes, I know that can be performed manually via LineTrace and such, but A_CustomRailGun can be convenient under some circumstances, and the way the aim currently works makes no sense.
Suggestion: add either aim 3, or a flag (something like RGF_IGNORETARGET or RGF_DONTFORCEAIM) that disables all kinds of aiming completely.