I've run into a major problem in
Psychic. that I can't fix at all mod-side.
The mod redefines the Sigil for Strife, but the new version ("PsySigil") cannot actually inherit from Sigil because it needs to inherit from Psychic's base weapon definition to allow casing of altfires. Everything works as expected except for A_FireSigil1 emulation, which results in a nasty bug in which Spectres are unkillable due to the way the SPECTRAL flag is handled.
The problem is on line 989 of
p_interaction.cpp, in the function P_DamageMobj:
Code: Select all
...
else if (target->flags4 & MF4_SPECTRAL)
{
if (inflictor->FriendPlayer == 0 && !target->IsHostile(inflictor)) // Line 989
return;
}
...
The problem is that any attempt to A_FireCustomMissile a
SpectralLightningSpot results in the projectiles "forgetting" which player shot it (i.e. inflictor->FriendPlayer becomes zero) and causing the check on Line 989 to 'pass' and break out of P_DamageMobj. This results in a SPECTRAL projectile which successfully impacts the monster but deals no damage.
I thought the trouble with SpectralLightningSpot was due to it not actually being a projectile, but I've tried redefining it with +MISSILE (and +FLOORHUGGER and a bunch of A_ScaleVelocity hacks) and using A_SpawnItemEx with SXF_TRANSFERPOINTERS to spawn the SpectralLightningV1/V2 projectiles, but no matter what I do, I can't get the engine to pass the check.
The purpose of this check, if I'm interpreting it correctly, is to not take damage from Spectral projectiles unless a player fired it or the monster who shot it is hostile toward the target, presumably to prevent infighting between Spectres and EntitySecond actors unless Thing_Hate is used. The trouble is that it also cancels damage from this projectile in a way I cannot figure out how to fix, and some way around this or alternative to this hardcoded check would be most welcome. As-is, I cannot figure out how on Earth to emulate Sigil 1's attack without running into this issue, which throws a monkey wrench into Strife modding.
I've run into a major problem in [url=http://forum.zdoom.org/viewtopic.php?f=19&t=21681]Psychic[/url]. that I can't fix at all mod-side.
The mod redefines the Sigil for Strife, but the new version ("PsySigil") cannot actually inherit from Sigil because it needs to inherit from Psychic's base weapon definition to allow casing of altfires. Everything works as expected except for A_FireSigil1 emulation, which results in a nasty bug in which Spectres are unkillable due to the way the SPECTRAL flag is handled.
The problem is on line 989 of [b]p_interaction.cpp[/b], in the function P_DamageMobj:
[code]...
else if (target->flags4 & MF4_SPECTRAL)
{
if (inflictor->FriendPlayer == 0 && !target->IsHostile(inflictor)) // Line 989
return;
}
...[/code]
The problem is that any attempt to A_FireCustomMissile a [url=http://zdoom.org/wiki/Classes:SpectralLightningSpot]SpectralLightningSpot[/url] results in the projectiles "forgetting" which player shot it (i.e. inflictor->FriendPlayer becomes zero) and causing the check on Line 989 to 'pass' and break out of P_DamageMobj. This results in a SPECTRAL projectile which successfully impacts the monster but deals no damage.
I thought the trouble with SpectralLightningSpot was due to it not actually being a projectile, but I've tried redefining it with +MISSILE (and +FLOORHUGGER and a bunch of A_ScaleVelocity hacks) and using A_SpawnItemEx with SXF_TRANSFERPOINTERS to spawn the SpectralLightningV1/V2 projectiles, but no matter what I do, I can't get the engine to pass the check.
The purpose of this check, if I'm interpreting it correctly, is to not take damage from Spectral projectiles unless a player fired it or the monster who shot it is hostile toward the target, presumably to prevent infighting between Spectres and EntitySecond actors unless Thing_Hate is used. The trouble is that it also cancels damage from this projectile in a way I cannot figure out how to fix, and some way around this or alternative to this hardcoded check would be most welcome. As-is, I cannot figure out how on Earth to emulate Sigil 1's attack without running into this issue, which throws a monkey wrench into Strife modding.