Sanitize autoloading

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Sanitize autoloading

Re: Sanitize autoloading

by Graf Zahl » Wed Apr 08, 2015 1:22 pm

Don't overthink it.

The case is not an issue, the config is case insensitive.
As for Urban Brawl, no. If there's ever another Action Doom IWAD it will most likely be so different that there's no point assigning the same group to both. And even if there is, renaming sections if the need arises is trivial.

Re: Sanitize autoloading

by vanhofen » Wed Apr 08, 2015 1:05 pm

Can be the case-difference a problem in the future? All Autoload-entrys are lowercase (doom.Autoload), but all other entrys in user's ini-file are capitalized (Doom.AutoExec or Doom.Bindings).

Btw: "urbanbrawl.Autoload" should be renamed to "actiondoom.Autoload" or "actiondoom.urbanbrawl.Autoload". The name of this game is Actiondoom. Urbanbrawl is the subname of the prequel. See http://doomwiki.org/wiki/Action_Doom_2:_Urban_Brawl

Re: Sanitize autoloading

by Gez » Tue Apr 07, 2015 3:38 pm

I'm just sad neither of the versions gets "square.enix".

Re: Sanitize autoloading

by Blzut3 » Tue Apr 07, 2015 3:27 pm

MTrop wrote:It's just so that both we and end-users can immediately tell each version apart.
Right. But why should I as a ZDoom dev care about your setup? From an end user perspective you're going to release the first episode with bug fixes until you release the complete game. At which point the single episode version is useless. Unless you have intentions to sell the complete game I see no reason for ZDoom to detect multiple editions besides "because it technically can."

This is seriously up there with the "Freedoom Demo" which I'm glad is no longer actually a thing.

Re: Sanitize autoloading

by MTrop » Tue Apr 07, 2015 2:31 pm

Our current build of Square is split in such a way that it is possible to build both Full Game assets and Episode 1 assets only. This was so that anything we updated in Episode 1 makes it into the Full Game, and any single-episode promo builds can be made separately for conventions/demos/what-have-you.

Episode 1 assembles to "square1.pk3." The full game (and other dev versions) assemble to "square.pk3." They each contain different sets of files, and can be exclusively detectable. It's just so that both we and end-users can immediately tell each version apart.

The Episode 1 release will be replaced completely once the full game is released. We still bundle a version of ZDoom with a modified zdoom.pk3 in with Square, anyway, but this will ease the transition between E1 and Full if people want to keep their versions of ZDoom up to date with the Git builds.

Official input from a Square Co-Developer: "square.full" and "square.squareware" is okay, but any way you name it is fine. However, both versions should remain.

Re: Sanitize autoloading

by Blzut3 » Tue Apr 07, 2015 2:02 pm

I'm personally still confused as to what the point of supporting two versions of Adventures of Square is considering the eventual full release will strictly supersede the existing release?

Re: Sanitize autoloading

by Xaser » Tue Apr 07, 2015 10:02 am

Indeed. "Square-ware" is the E1-only release, similar to doom1.wad ("Shareware", hence the dumb pun). The full release will be 3 episodes, so calling it "square.episode1" wouldn't make sense.

Personally, I'd prefer "square.full" and "square.squareware", as originally suggested, as it more closely mirrors "doom.doom1.registered" and "doom.doom1.shareware" (and also the verbiage we dev-folk use internally). But TBH either setup is fine, so long as it's documented somewhere for RTFM purposes. :P

[/semi_official_input_from_square_co-developer]

Re: Sanitize autoloading

by Graf Zahl » Tue Apr 07, 2015 5:14 am

The current episode 1 download is the 'square-ware' version so it's safe to assume that the full game will eventually fill the other slot, meaning there's no need to change it.

Re: Sanitize autoloading

by vanhofen » Tue Apr 07, 2015 4:53 am

I am also not really familar with Square - just playing it. ^^
But take a look at it's website (http://adventuresofsquare.com/downloads.php). The current square1.pk3 is named "The Adventures of Square, Episode 1". With the knowledge that this project is still under development the suggested changes are maybe not wrong.

Aber entscheide selbst.

Re: Sanitize autoloading

by Graf Zahl » Tue Apr 07, 2015 4:40 am

The Strife changes are not needed. The teasers cannot autoload anything, it's shareware-blocked, the name is merely there so that IWAD specific definition files can be loaded from zdoom.pk3.

Regarding Adventures of Square, I cannot say, I'm not familiar with the project and its future plans, so before changing anything I need more info.

Re: Sanitize autoloading

by vanhofen » Tue Apr 07, 2015 4:28 am

And maybe some more future-stable changes?

Code: Select all

diff --git a/wadsrc/static/iwadinfo.txt b/wadsrc/static/iwadinfo.txt
index a274a1f..60c395a 100644
--- a/wadsrc/static/iwadinfo.txt
+++ b/wadsrc/static/iwadinfo.txt
@@ -3,7 +3,7 @@
 IWad
 {
        Name = "The Adventures of Square"
-       Autoname = "square.square"
+       Autoname = "square.episode1"
        Game = "Doom"
        Config = "Square"
        MustContain = "SQU-IWAD", "E1A1"
@@ -13,7 +13,7 @@ IWad
 IWad
 {
        Name = "The Adventures of Square (Square-ware)"
-       Autoname = "square.squareware"
+       Autoname = "square.episode1.squareware"
        Game = "Doom"
        Config = "Square"
        MustContain = "SQU-SWE1", "E1A1"
@@ -56,7 +56,7 @@ IWad
 IWad
 {
        Name = "Action Doom 2: Urban Brawl"
-       Autoname = "urbanbrawl"
+       Autoname = "actiondoom.urbanbrawl"
        Game = "Doom"
        Config = "UrbanBrawl"
        Mapinfo = "mapinfo/urbanbrawl.txt"

Re: Sanitize autoloading

by vanhofen » Tue Apr 07, 2015 4:15 am

What about Strife? Maybe this?

Code: Select all

diff --git a/wadsrc/static/iwadinfo.txt b/wadsrc/static/iwadinfo.txt
index a274a1f..e39005f 100644
--- a/wadsrc/static/iwadinfo.txt
+++ b/wadsrc/static/iwadinfo.txt
@@ -90,7 +90,7 @@ IWad
 IWad
 {
        Name = "Strife: Quest for the Sigil"
-       Autoname = "strife"
+       Autoname = "strife.strife"
        Game = "Strife"
        Config = "Strife"
        Mapinfo = "mapinfo/strife.txt"
@@ -104,7 +104,7 @@ IWad
        Name = "Strife: Teaser (New Version)"
        Game = "Strife"
        Config = "Strife"
-       Autoname = "strifeteaser2"
+       Autoname = "strife.teaser2"
        Mapinfo = "mapinfo/strife.txt"
        Compatibility = "Shareware", "Teaser2"
        MustContain = "MAP33", "ENDSTRF", "INVCURS"
@@ -116,7 +116,7 @@ IWad
        Name = "Strife: Teaser (Old Version)"
        Game = "Strife"
        Config = "Strife"
-       Autoname = "strifeteaser1"
+       Autoname = "strife.teaser1"
        Mapinfo = "mapinfo/strife.txt"
        Compatibility = "Shareware"
        MustContain = "MAP33", "ENDSTRF"
Anyway: Is it usefull to allow autoloads for the teaser-versions of Strife?

Re: Sanitize autoloading

by vanhofen » Tue Apr 07, 2015 12:52 am

So i would prefer a name-system like chex.chex3

//Oh, it's already done. Fine.

Re: Sanitize autoloading

by Graf Zahl » Tue Apr 07, 2015 12:38 am

You are probably correct. Fortunately it's not too late to improve what's there. :)

Re: Sanitize autoloading

by vanhofen » Tue Apr 07, 2015 12:17 am

Great solution. Thx.

But note: When you're going to use "doom2" as a subgame of "doom" (like "doom.doom2") you should use this system in other games too. That means to rename e.g. "chex.3" to "chex.chex3". Same in hacx.

//edit:
Or rename the subgames for doom and freedoom to the digit-system like in chex or hacx. But i think you shouldn't mix it.

Top