ZDoom

Please submit new bug reports next time. It's not ideal for developers or contributors to fix bugs in a section that's CLOSED.

Anyway, I'll fix this.

Actor WeaponHit
{
	+NOBLOCKMAP
	+NOGRAVITY
	+ALWAYSPUFF
	+PUFFONACTORS
	+HITTARGET
	States
	{
		Spawn:
			TNT1 A 0
		XDeath:
			UNKN A 35 A_GiveInventory("Disintegration", 1, AAPTR_TARGET)
			Stop
	}
}

if (puffDefaults->flags7 && MF7_HITTARGET) puff->target = trace.Actor;
if (puffDefaults->flags7 && MF7_HITMASTER) puff->master = trace.Actor;
if (puffDefaults->flags7 && MF7_HITTRACER) puff->tracer = trace.Actor;

P_SpawnPuff(source, puffclass, x, y, z, (source->angle + angleoffset) - ANG90, 1, puffflags);

if (puffclass != NULL) thepuff = Spawn(puffclass, source->x, source->y, source->z, ALLOW_REPLACE);

Sorry to bump this, but has anyone had any luck getting this to work on puffs spawned by rail or standard bullet attacks?

This doesn't work, even thought the graphical part of the puff spawns:
[code]Actor WeaponHit
{
+NOBLOCKMAP
+NOGRAVITY
+ALWAYSPUFF
+PUFFONACTORS
+HITTARGET
States
{
Spawn:
TNT1 A 0
XDeath:
UNKN A 35 A_GiveInventory("Disintegration", 1, AAPTR_TARGET)
Stop
}
}[/code]

I've tried all of the Master/Tracer/Target variants, and assigned the puff to both rail and bullet attacks, with no luck. The UNKNA0 sprite shows up, but nothing is given. Using the same technique on a true projectile works fine.

EDIT:
For P_LineAttack, lines 769-771 of p_map.cpp have:[code]if (puffDefaults->flags7 && MF7_HITTARGET) puff->target = trace.Actor;
if (puffDefaults->flags7 && MF7_HITMASTER) puff->master = trace.Actor;
if (puffDefaults->flags7 && MF7_HITTRACER) puff->tracer = trace.Actor;[/code]Too many '&'s!

EDIT2:
For P_RailAttack, Line 4214:
[code]P_SpawnPuff(source, puffclass, x, y, z, (source->angle + angleoffset) - ANG90, 1, puffflags);
[/code] This spawns the puff, but doesn't assign that puff as 'thepuff', so I think that's why the actor pointers don't get assigned to that spawned puff.

Though I'm also not quite sure what line 4182 is trying to do:
[code]if (puffclass != NULL) thepuff = Spawn(puffclass, source->x, source->y, source->z, ALLOW_REPLACE);
[/code] Is it supposed to spawn a puff at the rail origin?

[quote="Major Cooke"]Throw in what?[/quote]Your most recent addition. It seems it's been merged, so apparently the devs are cool with it.

[quote="NeuralStunner"]A formal suggestion might've needed to be along the lines of separate flags-SNIP-[/quote]
No it doesn't. It can be super simple and it'd still fit the thread unless mods say otherwise. Pin the blame on me if they do, 'cause it's truthfully me who said it. :P You must not have seen some of my other suggestions back before I got into this coding.

Throw in what?

I was primarily seeking your opinion on the idea, first. A formal suggestion might've needed to be along the lines of separate flags for bouncing behaviors. If you're okay with throwing it in now then that's fine, too. :P

[url=https://github.com/rheit/zdoom/pull/195]Done.[/url] Though next time, please do make a feature suggestions thread instead of asking in a bug report. :P

One last thought: What about integrating these behaviors with bouncing? I have a situation in which I'd like to make a missile react to certain enemies when it tries to bounce off them.

Added.

I'll look into it. I just dont like working with the bullet code because it's confusing. Hard to tell sometimes if it's thepuff or puffDefaults on whom should get these things.

[quote="NeuralStunner"][quote="D2JK"]Though I wish it worked for puffs too, but hey.[/quote]Agreed, and I don't imagine it would be any harder to do. The puff-spawning code already "knows" about victims.[/quote]
Rail attacks are surprisingly easy to add that to as well.

[quote="D2JK"]Though I wish it worked for puffs too, but hey.[/quote]Agreed, and I don't imagine it would be any harder to do. The puff-spawning code already "knows" about victims.

It works now, thank you for another useful addition!

Though I wish it worked for puffs too, but hey.

[url=https://github.com/rheit/zdoom/pull/189]Whoops...[/url]

I can't get it to work either, trying to test the flag(s) with a code like this:
[spoiler][code]
Actor NewPlasmaBall : PlasmaBall replaces PlasmaBall
{
+HITMASTER
States
{
Death:
TNT1 A 0 A_GiveInventory("Thrust", 1, AAPTR_MASTER)
Goto Super::Death
}
}



Actor Thrust : CustomInventory
{
States
{
Pickup:
TNT1 A 0 A_ChangeVelocity(0,0,90)
Stop
}
}
[/code][/spoiler]

		if (target->flags7 & MF7_HITTARGET)	mo->target = target;
		if (target->flags7 & MF7_HITMASTER)	mo->master = target;
		if (target->flags7 & MF7_HITTRACER)	mo->tracer = target;

		if (mo->flags7 & MF7_HITTARGET)	mo->target = target;
		if (mo->flags7 & MF7_HITMASTER)	mo->master = target;
		if (mo->flags7 & MF7_HITTRACER)	mo->tracer = target;

According to Major Cooke's git log:
[quote]HITTARGET, HITMASTER, and HITTRACER.
A missile that dies hitting an actor will set this impacted actor as the new target/master/tracer, depending on specifications.[/quote] And according to the commentary in actor.h:
[quote] MF7_HITTARGET = 0x00004000, // The actor the projectile dies on is set to target, provided it's targetable anyway.
MF7_HITMASTER = 0x00008000, // Same as HITTARGET, except it's master instead of target.
MF7_HITTRACER = 0x00010000, // Same as HITTARGET, but for tracer.[/quote] The way I understand it, these flags are supposed to be used on missiles, correct? However, when I look at the code it seems that it's the victim's flags which are checked rather than the missile's.

This is what it looks like right now:
[code] if (target->flags7 & MF7_HITTARGET) mo->target = target;
if (target->flags7 & MF7_HITMASTER) mo->master = target;
if (target->flags7 & MF7_HITTRACER) mo->tracer = target;[/code]
But shouldn't it check mo's (the missile's) flags, like so?
[code] if (mo->flags7 & MF7_HITTARGET) mo->target = target;
if (mo->flags7 & MF7_HITMASTER) mo->master = target;
if (mo->flags7 & MF7_HITTRACER) mo->tracer = target;[/code]