[GZDoom commit 925305a] 3D Floor crash

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [GZDoom commit 925305a] 3D Floor crash

Re: [GZDoom commit 925305a] 3D Floor crash

by Graf Zahl » Mon Jul 28, 2014 2:25 pm

fixed.

The hard crash was indeed UDMF only and my last commit already fixed it.
The heap corruption, though, had nothing to do with 3D floors, it was just random chance that you discovered it only in these maps.

Re: [GZDoom commit 925305a] 3D Floor crash

by everamzah » Mon Jul 28, 2014 1:10 pm

Is it because of the map format? UDMF vs. Hexen format for example?
Image

Re: [GZDoom commit 925305a] 3D Floor crash

by Ed the Bat » Mon Jul 28, 2014 1:02 pm

everamzah wrote:I couldn't find Enjay's Burghead mod.
http://www.doomworld.com/idgames/index. ... bgpabh.zip

Re: [GZDoom commit 925305a] 3D Floor crash

by everamzah » Mon Jul 28, 2014 12:46 pm

I couldn't find Enjay's Burghead mod. I made a simple test map and it crashes here. https://www.dropbox.com/s/a6o9m8cxllpk39l/160test.wad

Re: [GZDoom commit 925305a] 3D Floor crash

by Graf Zahl » Mon Jul 28, 2014 12:33 pm

Yes, I used Enjay's Burghead mod.

Re: [GZDoom commit 925305a] 3D Floor crash

by everamzah » Mon Jul 28, 2014 12:31 pm

Did the map you tried testing with have 3D floors? Specifically Sector_Set3dFloor?

Re: [GZDoom commit 925305a] 3D Floor crash

by Graf Zahl » Mon Jul 28, 2014 10:02 am

I wasn't able to reproduce this with any map I tested, but there was definitely something wrong here. The dirty setting was called in some places where it shouldn't, in particular from the map init code where not everything was properly set up yet.

Re: [GZDoom commit 925305a] 3D Floor crash

by Kyle873 » Mon Jul 28, 2014 9:22 am

Can also confirm this.

Re: [GZDoom commit 925305a] 3D Floor crash

by everamzah » Mon Jul 28, 2014 7:51 am

Same here.

[GZDoom commit 925305a] 3D Floor crash

by Ryan Cordell » Mon Jul 28, 2014 6:40 am

For whatever reason, this recent commit https://github.com/coelckers/gzdoom/com ... 497ec4b9f9 for updating the vertex dirty states ends up crashing GZDoom hard whenever it encounters a map with 3D floors, such as DoomRPGs Outpost (a more innocent crash) or, even worse, Stronghold (a heap error!). Tested on a clean build, both me and Edward850 can confirm it's happened to both of us.

Top