[2.8pre-362] Heretic gargolyes and fire gargs should infight

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: [2.8pre-362] Heretic gargolyes and fire gargs should infight

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Graf Zahl » Wed May 14, 2014 5:06 am

This got already fixed by an external pull request.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Graf Zahl » Sun Mar 16, 2014 4:05 pm

The last time this got rejected the species property did not exist yet. Now that it exists there's no reason to restore the original behavior.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Blzut3 » Sun Mar 16, 2014 1:23 pm

For reference here's a link to the last thread I can find on the issue: http://forum.zdoom.org/viewtopic.php?f=7&t=21967

Personally I'm in the camp that accuracy should be preserved where reasonable (like in this case where we already have the means to restore the behavior). Certainly anyone wanting the more logical behaviors could just load a mod?

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by _mental_ » Sun Mar 16, 2014 3:28 am

Gez wrote:Nah, the species property will bypass inheritance, so there is no need to copy/paste stuff.
Indeed, an addition of a single line like below to the corresponding actor solves the problem.

Code: Select all

Species "HereticImpLeader"
However I found no way to control this behavior by user yet.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Gez » Sat Mar 15, 2014 11:21 am

Nah, the species property will bypass inheritance, so there is no need to copy/paste stuff. See Hexen's chaos serpents, Demon1 and Demon2 retain their inheritance link but are no longer the same species.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by _mental_ » Sat Mar 15, 2014 9:27 am

Ed the Bat wrote:It can be easily fixed by giving the fire gargoyle a new "species" property.
To do so HereticImpLeader class must not be derived from HereticImp class in Decorate definitions. The same for golems/nitrogolems and their ghosted versions. So lots of stuff must be copy-pasted.
An alternative solution is to add special case for the mentioned three classes to AActor::GetSpecies() function. Kind of a dirty hack though.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by plums » Thu Mar 13, 2014 2:58 pm

Graf Zahl wrote:Yes, it's well known. ZDoom considers both the same species due to the way they are defined.
Gez wrote:Thing is, the last time this popped up it was decided the ZDoom behavior was more logical and made more sense, so it was deemed a [won't change].
Understood, sorry for the duplicate.
Zhs2 wrote:This makes me wonder if Golems and NitroGolems should also be capable of infighting.
They do in fact infight in Vanilla.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Gez » Wed Mar 12, 2014 2:02 pm

Thing is, the last time this popped up it was decided the ZDoom behavior was more logical and made more sense, so it was deemed a [won't change].

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Ed the Bat » Wed Mar 12, 2014 12:51 pm

Graf Zahl wrote:Yes, it's well known. ZDoom considers both the same species due to the way they are defined.
It can be easily fixed by giving the fire gargoyle a new "species" property.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by NeuralStunner » Wed Mar 12, 2014 11:53 am

Graf Zahl wrote:The gargoyles do not do damage with their charge attacks. They only use it to move into an attacking position faster.
Amusing: In vanilla, they'd still trigger a pain sound on impacting the player. You can avoid damage but still go "ouch".

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Zhs2 » Wed Mar 12, 2014 11:36 am

This makes me wonder if Golems and NitroGolems should also be capable of infighting.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Blue Shadow » Wed Mar 12, 2014 9:36 am

*huge facepalm*

Oh yeah, that was stupid of me. I forgot that they don't do damage when charging, to begin with...

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Graf Zahl » Wed Mar 12, 2014 8:30 am

The gargoyles do not do damage with their charge attacks. They only use it to move into an attacking position faster.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Blue Shadow » Wed Mar 12, 2014 4:01 am

plums wrote:A regular gargoyle should never infight with another regular gargoyle, but I'm pretty sure they don't currently. (It's a little hard to get them to charge into one another to see.)
Why don't they, by the way? I mean, they A_SkullAttack their targets just like lost souls do, but they don't get damaged and they don't infight when they accidentally hit each other.

Re: [2.8pre-362] Heretic gargolyes and fire gargs should inf

by Graf Zahl » Wed Mar 12, 2014 2:02 am

Yes, it's well known. ZDoom considers both the same species due to the way they are defined.

Top