by Jekyll Grim Payne » Sat Jan 06, 2024 7:44 am
Graf Zahl wrote: ↑Fri Jan 05, 2024 11:11 am
It's mainly because the menu to support the old method is a pile of toxic waste. Something here definitely needs to be done when the menus get updated.
Of course I then expect the same to happen as with the menu when ZDoom's long standing change of the scaling was undone:
You get hundreds of compaints asking "How can I restore it to the old way?"
Could this be alleviated by adding an option to OptionMenu items that allows specifying an explicit value for graycheck rather than having IsGrayed() return true whenever the value is 0? This way we would be able to modify the menu in such a way that it has a toggle for hud_oldscale (something like "Old hud scaling"), a slider for "Incremental scalefactor" (or whatever you'd like to call it) that becomes properly grayed-out when hud_oldscale is true, while the traditional Fullscreen HUD scaling becomes grayed-out when it's false. Because if so, that's something I've considered doing and I can make a PR for that.
UPD: to demonstrate:
And naturally, it'd be left at On by default, so that the old users don't see any sudden changes.
Also, semi-related, is there a reason why hud_scalefactor couldn't go above 1.0? I'm sure it would have its uses, especially on wider displays.
UPD: Okay, I went ahead and made a PR:
https://github.com/ZDoom/gzdoom/pull/2352
[quote="Graf Zahl" post_id=1248995 time=1704474693 user_id=75]
It's mainly because the menu to support the old method is a pile of toxic waste. Something here definitely needs to be done when the menus get updated.
Of course I then expect the same to happen as with the menu when ZDoom's long standing change of the scaling was undone:
You get hundreds of compaints asking "How can I restore it to the old way?"
[/quote]
Could this be alleviated by adding an option to OptionMenu items that allows specifying an explicit value for graycheck rather than having IsGrayed() return true whenever the value is 0? This way we would be able to modify the menu in such a way that it has a toggle for hud_oldscale (something like "Old hud scaling"), a slider for "Incremental scalefactor" (or whatever you'd like to call it) that becomes properly grayed-out when hud_oldscale is true, while the traditional Fullscreen HUD scaling becomes grayed-out when it's false. Because if so, that's something I've considered doing and I can make a PR for that.
UPD: to demonstrate:
[streamable]psbg39[/streamable]
And naturally, it'd be left at On by default, so that the old users don't see any sudden changes.
Also, semi-related, is there a reason why hud_scalefactor couldn't go above 1.0? I'm sure it would have its uses, especially on wider displays.
UPD: Okay, I went ahead and made a PR: https://github.com/ZDoom/gzdoom/pull/2352