This can't be right, can it?

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: This can't be right, can it?

by randi » Mon Apr 10, 2006 5:49 pm

There, now you can only move topics to forums you can moderate.

by Siggi » Mon Apr 10, 2006 3:57 pm

Image
Hehehe, oops :wink:

by Graf Zahl » Mon Apr 10, 2006 3:26 pm

I just noticed that I accidentally moved a handful of reports twice - and they ended up in News. Too bad I can't move them back where they belong... :?

by TheDarkArchon » Mon Apr 10, 2006 3:00 pm

At that time, when I had looked at the new posts, this and another bug report was in the news forum, according to the search

by Graf Zahl » Mon Apr 10, 2006 2:44 pm

What's in News?

by TheDarkArchon » Mon Apr 10, 2006 2:38 pm

It wasn't in news a minute ago....

by Graf Zahl » Mon Apr 10, 2006 2:32 pm

fixed

by Scuba Steve » Tue May 17, 2005 12:10 pm

That's how sweet I am, I found this error out all by myself.

by Graf Zahl » Sun Apr 10, 2005 4:44 am

One more in the same file:

This line in P_FireWeapon should check for the bAltFire flag, otherwise it won't work correctly once alternative fire is actually implemented.

Code: Select all

	if (weapon == NULL || !weapon->CheckAmmo (AWeapon::PrimaryFire, true))

Re: [source code] This can't be right, can it?

by Graf Zahl » Fri Apr 01, 2005 7:48 am

It should read

Code: Select all

	if (weapon == NULL || weapon->WeaponFlags & WIF_DONTBOB)


Randy just used the wrong flags variable to check the flag. The effect would be that the DONTBOB flag doesn't work and that the SHOOTABLE flag has an unintended side effect if used on a weapon.

Re: [source code] This can't be right, can it?

by Cutmanmike » Fri Apr 01, 2005 6:42 am

Graf Zahl wrote:

Code: Select all

	if (weapon == NULL || weapon->flags & WIF_DONTBOB)
(found in P_BobWeapon)

Unless you really want to use MF_SHOOTABLE to indicate non-bobbing weapons...
What would this effect?

by Graf Zahl » Fri Apr 01, 2005 6:13 am

Same problem in P_CheckWeaponFire:

Code: Select all

		if (!(player->oldbuttons & BT_ATTACK) || !(weapon->flags & WIF_NOAUTOFIRE))

[source code] This can't be right, can it?

by Graf Zahl » Fri Apr 01, 2005 5:59 am

Code: Select all

	if (weapon == NULL || weapon->flags & WIF_DONTBOB)
(found in P_BobWeapon)

Unless you really want to use MF_SHOOTABLE to indicate non-bobbing weapons...

Top