[GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bots"

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bots"

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by _mental_ » Mon Sep 17, 2018 11:09 pm

Yep, it was a single line of code.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by Enjay » Mon Sep 17, 2018 2:44 pm

Probably by a tiny error in thousands of lines of code affecting a game mode that the devs don't play very often?

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by PixelWAD » Mon Sep 17, 2018 2:36 pm

Once I'm back from holiday I'll check the most modern build and see if it fixed the issues I was experiencing.

On the other hand, how did this bug occurred in 3.5.1 in the first place? It's not only about bots. I can't even changemap in multiplayer mode, or even change gameplay settings.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by Rachael » Mon Sep 17, 2018 4:04 am

In fact, if the issue is not reported, make sure to report it. If it's already reported, please add as many details as you can.

What you see at a given moment in Dev Builds is always going to be a candidate for whatever release may be following them.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by _mental_ » Sun Sep 16, 2018 11:23 pm

If you think that stable versions are built from some different codebase that magically solves all issues then you are wrong.
The next major release would be exactly the same as the last devbuild with exception of its version number.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by PixelWAD » Sun Sep 16, 2018 7:10 pm

I have to roll back to 3.5.0 and wait for more stable version. I'm having issues with dev builds.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by Siberian Tiger » Sun Sep 16, 2018 3:50 pm

_mental_ wrote:This was fixed in 5b7d3c9.
Thank you for the feedback and a big thanks to the Devs for keeping this port alive! :D
I will discard the demonstration video as it is unnecessary presently.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by _mental_ » Sun Sep 16, 2018 6:42 am

This was fixed in 5b7d3c9.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by camper » Wed Sep 05, 2018 8:28 am

Is there any other way to add bots to the game?

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by drfrag » Sun Sep 02, 2018 12:18 pm

AFAIK it's fixed in recent devbuilds.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by Siberian Tiger » Sun Sep 02, 2018 12:04 pm

PixelWAD wrote:I have the same issue. Is there a workaround or I need to reverse to previous version?
I am unaware of a workaround, but if you need that functionality - merely roll back to GZDoom 3.5.0 until the issue is resolved.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by PixelWAD » Sat Sep 01, 2018 9:16 pm

I have the same issue. Is there a workaround or I need to reverse to previous version?

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by Graf Zahl » Sun Aug 26, 2018 12:00 am

The difference is, now player_t explicitly initializes its settings_controller member variable, the old implementation did not. Apparently there are some dirty side effects at work here which depend on the value not getting cleared on a player reset. A player reset has always been supposed to be complete, so I had changed the inline initialization to set all fields, including the ones that were left in the old version. In this case it apparently just hid a bug in the implementation that, from the looks of it, does not properly set up this thing when a player gets reset.

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by drfrag » Sat Aug 25, 2018 6:24 pm

Haven't checked but i think the problem was introduced in "- got rid of FNameNoInit and made the default constructor of FName non-initializing."

Re: [GZDoom 3.5.1]Bug: "Only Settings Controller Can Add Bot

by Rachael » Sat Aug 25, 2018 3:54 pm

This bug is easy to confirm, just did in 3.5.1. I unfortunately don't have the time to look into it but I suspect a variable init got broken or omitted somewhere.

Top