Savegame thumbnails are generated incorrectly

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Savegame thumbnails are generated incorrectly

Re: Savegame thumbnails are generated incorrectly

by _mental_ » Sun Jun 03, 2018 7:57 am

It's a quite weird story about those weapons on saved games thumbnails.
It appeared to be inconsistencies between renderers, between the same renderer but different versions, and between various options in a particular version.
IMHO we need to stick to one decision regardless of renderers, setting, etc. Or probably to make this an option, which it seems a bit more complicated.

Re: Savegame thumbnails are generated incorrectly

by Marisa the Magician » Sun Jun 03, 2018 7:49 am

Works fine here too, and iirc the weapon has never been visible before.

Re: Savegame thumbnails are generated incorrectly

by Nash » Sun Jun 03, 2018 7:12 am

This may be a matter of preference but IMO the thumbnails should have the weapon art baked in.

Re: Savegame thumbnails are generated incorrectly

by _mental_ » Sun Jun 03, 2018 6:55 am

Works fine for me in every combination of post-processing effects I tried.

I just noticed one discrepancy with saved game thumbnails.
When bloom is enabled player's weapon is visible, without post-processing or with any other effect(s) it's hidden.
Actually, what is the correct behavior? Should weapon be visible on these pictures?

Re: Savegame thumbnails are generated incorrectly

by dpJudas » Sun Jun 03, 2018 6:18 am

Please try again now. I pushed a commit that I think fixes this.

Re: Savegame thumbnails are generated incorrectly

by _mental_ » Sat Jun 02, 2018 8:39 am

It's the same issue. Most of postprocessing effects break saved game thumbnail in one way or another.

Re: Savegame thumbnails are generated incorrectly

by XxMiltenXx » Sat Jun 02, 2018 8:32 am

I also have a savegame thumbnail issue that might be related:
FXAA-Savegame.png
This happens under Windows 10 (build 10.0.16299.431) when FXAA is enabled. I used a new INI file and simply enabled FXAA (doesn't matter which quality setting)

Re: Savegame thumbnails are generated incorrectly

by dpJudas » Sat Jun 02, 2018 8:11 am

Okay, I'll take a look soon. Based on the screen shots, it probably has something to do with glViewport not being what the screenshot code reading from the back buffer expects.

Re: Savegame thumbnails are generated incorrectly

by Graf Zahl » Sat Jun 02, 2018 4:36 am

I'll leave this to dpJudas then. Apparently I missed something important about the setup and I do not want to make it worse.

Re: Savegame thumbnails are generated incorrectly

by _mental_ » Sat Jun 02, 2018 4:26 am

It should be enough to have gl_tonemap 1 and everything else by default.
BTW tonemap and lens distortion give even more weird picture
savepic.png
savepic.png (67.07 KiB) Viewed 456 times
Screen resolution is 1440x900, thumbnail size is 216x162 and this corresponds to black rectangle in the corner.
This seems to be introduces with this commit and it's somehow related to switching of render buffers target textures.

Re: Savegame thumbnails are generated incorrectly

by Graf Zahl » Sat Jun 02, 2018 4:05 am

I cannot reproduce this with any tonemap (or other postprocessing) effect.

Re: Savegame thumbnails are generated incorrectly

by _mental_ » Fri Jun 01, 2018 2:56 am

I managed to reproduce this on Windows. Enable tone mapping (set gl_tonemap CVAR to true) and the bug will appear.

Re: Savegame thumbnails are generated incorrectly

by fakemai » Fri Jun 01, 2018 2:30 am

Thought I'd give it a go with your INI and a current Git build (2d50f535ff666a9cb0a0d3fe97c31f07e5a6f9a8) but couldn't reproduce. Am running Debian Stable, but also an ancient Intel GM45, so don't put too much faith in this. It could well be system-dependent though.

Re: Savegame thumbnails are generated incorrectly

by Marisa the Magician » Thu May 31, 2018 5:17 pm

https://marisakirisa.me/tmp/gzdoom.ini

(refresh if it gave you a 403, seems like the permissions got a bit screwy when I uploaded the file)

Re: Savegame thumbnails are generated incorrectly

by _mental_ » Thu May 31, 2018 2:59 am

Cannot reproduce this on Ubuntu 16.04 VM. Could you please attach your .ini file?

Top