Proposition(s) for colors w-z

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies
BBCode is OFF
Smilies are ON
Topic review
   

Expand view Topic review: Proposition(s) for colors w-z

Re: Proposition(s) for colors w-z

by Blue Shadow » Sun Sep 24, 2017 3:08 pm

Nash wrote:ACC headers needs to be updated with the new colours: https://github.com/rheit/acc/blob/master/zdefs.acs
Made a pull request for this: https://github.com/rheit/acc/pull/71

Re: Proposition(s) for colors w-z

by Ichor » Sat Sep 23, 2017 5:56 pm

Graf Zahl wrote:Why? You can specify colors directly by name. It made some sense to complete the list but there won't be any more.
heh ok

Re: Proposition(s) for colors w-z

by Nash » Sat Sep 23, 2017 4:40 pm

ACC headers needs to be updated with the new colours: https://github.com/rheit/acc/blob/master/zdefs.acs

Re: Proposition(s) for colors w-z

by Graf Zahl » Sat Sep 23, 2017 4:24 pm

Why? You can specify colors directly by name. It made some sense to complete the list but there won't be any more.

Re: Proposition(s) for colors w-z

by Ichor » Sat Sep 23, 2017 3:35 pm

Jimmy wrote:Thanks. If anyone wants to pitch some alternatives there are plenty of ideas in Fuzzball's new text colors PK3, just check the spoilers on that page.
I suppose they could the option for \c0 through \c9 next.

Re: Proposition(s) for colors w-z

by Jimmy » Sat Sep 23, 2017 9:02 am

Oh geez thanks, haha. I was so lost doing it on the site anyway and really should've used GitKraken which I'm actually somewhat au fait with.

Cheers for adding these, was fun to put them together.

Re: Proposition(s) for colors w-z

by _mental_ » Sat Sep 23, 2017 3:24 am

You should do all edits in one branch. But GitHub in browser sucks anyway as it creates way too many commits if you need to modify bunch of files.
I think I'll compose one commit from your changes as I want to test them anyway.

EDIT: Works fine for me. I've changed padding a bit to look better with 4 spaces tabs and updated messages in Cocoa color test code.
Pull request is here.

Re: Proposition(s) for colors w-z

by Jimmy » Sat Sep 23, 2017 3:04 am

Okay I'll do a PR once I've got my head actually attached.

In trying to make one just now over the online GitHub repo I may have made all 8 crucial file edits in separate branches. I think I fucked up...? ?????

Re: Proposition(s) for colors w-z

by Hellser » Fri Sep 22, 2017 10:26 pm

I'm with xaser on this -- all four colors do rock. The fire one is just a delicious color to gaze at. Not to mention ice and sapphire as well. I think these will be a great addition.

(Side note: I don't like strife, but damn do those colors look GOOD on the strife big font)

Re: Proposition(s) for colors w-z

by Xaser » Fri Sep 22, 2017 6:51 pm

My two cents on this is that all 4 of those colors rock, and since we're all inevitably gonna nitpick and suggestify-it to death if we leave this open too long, I'd say just go with 'em. :P

[dislcaimer: not knockin' anyone who's suggested otherwise or anything -- I'm mostly saying this because I'm resisting the urge to do that exact thing myself. ;]

Re: Proposition(s) for colors w-z

by nazakomu » Fri Sep 22, 2017 6:24 pm

Shadow Hog wrote:Truthfully, "Teal" looks more like "Mint" to me. (Not that this is a problem; mint's still a really good color.)
Yeah, I absolutely agree with this!

If you want it to be more like "Teal", then you should darken it a bit and try to make it less white-ish. Though, I also like the idea of a "Mint", too.. :wink:

Re: Proposition(s) for colors w-z

by Shadow Hog » Fri Sep 22, 2017 1:08 pm

Truthfully, "Teal" looks more like "Mint" to me. (Not that this is a problem; mint's still a really good color.)

Re: Proposition(s) for colors w-z

by Jimmy » Fri Sep 22, 2017 11:29 am

Thanks. If anyone wants to pitch some alternatives there are plenty of ideas in Fuzzball's new text colors PK3, just check the spoilers on that page.

Re: Proposition(s) for colors w-z

by Rachael » Fri Sep 22, 2017 5:11 am

I like them, too.

Re: Proposition(s) for colors w-z

by Graf Zahl » Fri Sep 22, 2017 2:37 am

I like that fire color. The others aren't bad either.

Top