Gzdoom Nodebuilder fail to parse huge comments.

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

Post a reply

Smilies
:D :) :( :o :shock: :? 8-) :lol: :x :P :oops: :cry: :evil: :twisted: :roll: :wink: :geek: :ugeek: :!: :?: :idea: :arrow: :| :mrgreen: :3: :wub: >:( :blergh:
View more smilies

BBCode is OFF
Smilies are ON

Topic review
   

Expand view Topic review: Gzdoom Nodebuilder fail to parse huge comments.

Re: Gzdoom Nodebuilder fail to parse huge comments.

by ibm5155 » Sat Aug 12, 2017 6:18 am

Ty Graf :D

Re: Gzdoom Nodebuilder fail to parse huge comments.

by Graf Zahl » Sat Aug 12, 2017 1:42 am

This wasn't a bug in GZDoom. Its parser is well capable of handling long strings.
But the string buffer in ZDBSP was hardcoded to 4096 bytes, which I just expanded to 40960.

I also had to make a clone of its repo because I got no write access to Randi's.

Re: Gzdoom Nodebuilder fail to parse huge comments.

by ibm5155 » Sat Jul 29, 2017 9:15 am

if map comments aren't used by zdoom, couldn't the parser just ignore what's inside the string and just jump at the end of the ' " ' looking for a ';' symbol?

Re: Gzdoom Nodebuilder fail to parse huge comments.

by Graf Zahl » Sat Jul 29, 2017 8:39 am

It's only in ZDBSP which uses an older version of the parser where the parse buffer is a static array. I can extend it but not unlimit it.

Re: Gzdoom Nodebuilder fail to parse huge comments.

by _mental_ » Sat Jul 29, 2017 8:25 am

Topic's title is completely misleading.
Report sounds like a bug in GZDoom's embedded node builder but it's about an issue of ZDBSP in fact.

The string length limit is hardcoded indeed. Does someone have write access to this repository?

Re: Gzdoom Nodebuilder fail to parse huge comments.

by ibm5155 » Sat Jul 29, 2017 7:58 am

Image
This is what happens when I triy to save the map on gzdoom builder BF.
ZZYZX said it was a bug on Gzdoom NodeBuilder so I posted an example wad here.

Re: Gzdoom Nodebuilder fail to parse huge comments.

by _mental_ » Sat Jul 29, 2017 3:55 am

What's the error you got? Because I'm getting 'No player 1 start' which means that map was loaded fine.

Gzdoom Nodebuilder fail to parse huge comments.

by ibm5155 » Thu Jul 27, 2017 5:39 pm

Example wad with more than 4000 chars on a single comment.
Gzdoom builder can load and save that file but gzdoom/nodebuilder doesn't like to read that string.
Attachments
nodebuilderFail.wad
(4.88 KiB) Downloaded 21 times

Top