[r4172] 0 tic frames not always lasting 0 tics

[GFD]

I'm with Blzut on this one. Being able to ensure events happen immediately would be really useful for me - aside from the example pk3 in the OP, I've been able to fix a bunch of other things in the same project with this as well.
IMO, there's not much harm in experimenting to see if it can be fixed without any side-effects. Why not try to fix it?

[Enjay]

To me, it would make sense to have the behaviour that existed prior to this addition still be the default. That way no existing mods would be broken and some obscurish mods wouldn't be sitting there waiting to announce their brokenness as and when someone eventually came upon them (possibly after the release of an official version thereby creating an official version with backwards compatibility issues). The nature of this change does seem to be the kind of thing that is likely to make that happen.

However, there does seem to be a need for the new behaviour so something that can be applied to new actors but leave old actors as they were would seem to make sense and so a +NOEXTRATIC flag does seem to be a good solution at least as far as my end user perspective is concerned.

[selfish] I am not aware of anything in my mods that is broken by the current state of the change, so it is presently immaterial to me how it is finalised. [/selfish]

[Blzut3]

r4234 takes a different approach to solving the issue. The OP example, cammy, Nash's flashlight, and FishyClockwork's example all seem to be working.

[Enjay]

I can't check it myself ATM but I've put a build of r4234 up in case any one else wants to give it a whirl.
Usual place: http://svn.drdteam.org/zdoom/

[randi]

Added as a flag for r4240. (Any suggestions for a better name than NODELAY?)

The OP example should change this:

Code: Select all

Spawn:
    TNT1 A 0
    TNT1 A 0 A_PlaySound("cs/weapon/blade", 6) 

to this:

Code: Select all

Spawn:
    TNT1 A 0 NODELAY A_PlaySound("cs/weapon/blade", 6) 

[Nash]

I guess with this change, I should be encouraged to go through all of my mods and remove all those redundant first states and add the NODELAY flag to all of them...

[Graf Zahl]

Now that's infinitely better than all these half-baked hacks that were tried before.

[Enjay]

A state specific flag? Is this a new conept or are there already other similar flags?

Either way, it seems like a nice simple, easy to use solution.

[Graf Zahl]

Yes, there are 2 flags: 'Bright' and 'Fast'.

[Gez]

A state specific flag? Is this a new conept or are there already other similar flags?

See [wiki=Actor_states#State_keywords]wiki[/wiki].

[Enjay]

Doh! How did I not remember those - especially "Bright"?

[Enjay]

Just tried r4242 and GZDoom r1560. The problems with LWM's Cammy have returned with these versions and this time both problems are present in the one exe. ie the devastator enemy does not spawn bullet actors when it attacks and it doesn't produce smoke plumes from a damaged arm or from the scattering debris when the devastator explodes.

[edit]
In fact, the problems seem even more extensive than that. I noticed problems with a number of the enemies and the player weapons that I had not noticed as being part of the previous bugs. [/edit]

[Fishytza]

Just tried r4242 and discovered that, for some reason, when you kill something, anything at all, it simply vanishes as if the last frame in the 'Death' state was not -1. Just kill a zombieman, imp or whatever and prepare to sigh like I did.

Just did another run with Hexen, killed an ettin, it vanished, but then the entire game sort of froze. I could still look around, music was playing, but couldn't move and the other actors simply stopped moving.

EDIT: Tried Strife, punched the first acolyte, game 'froze', acolyte was in it's idle animation instead of attacking.

So I see my thread was merged here. What a relief.

[Enjay]

Right enough. That certainly spoils some of the fun. There are other problems with r4242 as well. I suspect that they are all related to the recent changes in the thread that I just linked to.

[Fishytza]

Code: Select all

    if (tics != -1)
    {
        // [RH] Use tics <= 0 instead of == 0 so that spawnstates
        // of 0 tics work as expected.
        if (tics <= 0)
        {
            if (state == NULL)
            {
                Destroy();
                return;
            }
            if (!SetState(state->GetNextState()))
                return;         // freed itself
        }
        tics--;
    }

I really think tics--; should be before the if statement like it used to be before this 'noextratic' came along. But the root of the problem could be elsewhere. (Not an expert, just frustrated because I can't believe this happened)