This can't be right, can it?

[Graf Zahl]

Code: Select all

	if (weapon == NULL || weapon->flags & WIF_DONTBOB)

(found in P_BobWeapon)

Unless you really want to use MF_SHOOTABLE to indicate non-bobbing weapons...

[Graf Zahl]

Same problem in P_CheckWeaponFire:

Code: Select all

		if (!(player->oldbuttons & BT_ATTACK) || !(weapon->flags & WIF_NOAUTOFIRE))

[Cutmanmike]

Code: Select all

	if (weapon == NULL || weapon->flags & WIF_DONTBOB)

(found in P_BobWeapon)

Unless you really want to use MF_SHOOTABLE to indicate non-bobbing weapons...

What would this effect?

[Graf Zahl]

It should read

Code: Select all

	if (weapon == NULL || weapon->WeaponFlags & WIF_DONTBOB)

Randy just used the wrong flags variable to check the flag. The effect would be that the DONTBOB flag doesn't work and that the SHOOTABLE flag has an unintended side effect if used on a weapon.

[Graf Zahl]

One more in the same file:

This line in P_FireWeapon should check for the bAltFire flag, otherwise it won't work correctly once alternative fire is actually implemented.

Code: Select all

	if (weapon == NULL || !weapon->CheckAmmo (AWeapon::PrimaryFire, true))

[Scuba Steve]

That's how sweet I am, I found this error out all by myself.

[Graf Zahl]

fixed

[TheDarkArchon]

It wasn't in news a minute ago....

[Graf Zahl]

What's in News?

[TheDarkArchon]

At that time, when I had looked at the new posts, this and another bug report was in the news forum, according to the search

[Graf Zahl]

I just noticed that I accidentally moved a handful of reports twice - and they ended up in News. Too bad I can't move them back where they belong...

[Siggi]

Hehehe, oops

[randi]

There, now you can only move topics to forums you can moderate.