ZDoom

Trying to enter a map that was loaded from a mod folder (as in, a real folder, not one inside an archive) which contains the text "maps" crashes gzdoom in version above 4.11.3a.

Probably some kind of oversight?

Setup:
Extract d2maps.zip into gzdoom folder Drag d2maps folder over gzdoom.exe
Launch with Doom 2 (for example)
Try to enter MAP01 (start Doom 2 campaign or via console command)
Crash.

As described above, in this case, teh folder name "d2maps" contains the word "maps" and thus, crashes. If the folder name is changed to, for example, "d2map" (not maps), it works and maps can be entered without crashing.

Code: C0000005 (Access Violation - tried to read address 0000000000000008) Address: 00007ff72a1d0bf1 Flags: 00000000

CrashReport.zip

Confirmed with personal mods as well as simple Doom2.
Confirmed to happen on other user's machines as well.

Update: Reason for bug has been found.

Trying to enter a map that was loaded from a mod folder (as in, a real folder, not one inside an archive) which contains the text "maps" crashes gzdoom in version above 4.11.3a.

For what it's worth, this isn't limited to "Maps", assuming it's the same bug. For example, I used to store my Deathstrider addons in GZDoom/Addons/DS Addons, and the crash happened when I tried loading an addon with path GZDoom/Addons/DS Addons/Konata Izumi, which just so happens to have an Addons folder in it. If I rename that folder to just A, it still crashes.

To summarize, here's what crashes:
Addons/DS Addons/Konata Izumi/A
Addons/DS Addons/Konata Izumi/Addons
Bddons/DS Addons/Konata Izumi/Addons
Bddons/DS Bddons/Konata Izumi/Bddons

Here's what doesn't:
Bddons/DS Bddons/Konata Izumi/Addons

Nowadays I use GZDoom/Add-ons/DS Add-ons and that prevents the crash from happening. Beats me why. Interestingly enough, loading an addon with the path Addons/DS Addons/Abaddon doesn't crash. At least not until I put a folder called A in Abaddon.

Crash report, though it's probably going to be the same as OP's. Code is certainly the same.

https://drive.google.com/file/d/1b6ZOfK ... sp=sharing