[4.12.2/4.12.1] Segfault when loading map from directory

[Alfred Don]

When this map is loaded from a pk3-structured directory, it segfaults.
This does not occur when loading the map directly as a wad, or in a pk3 file.

I've attached the crash log and test mod below, however, the test mod must be extracted to reproduce the issue.

Test wad: https://www.mediafire.com/file/vx9c6hxq ... d.zip/file
Crash log: https://www.mediafire.com/file/mm709xjf ... 9.log/file

Additionally, this map previously worked on 4.11.3, and it segfaults in the apt release of 4.12.1, and my own compiled version of 4.12.2.
I am running Ubuntu 22.04.04 LTS, on x86_64. I have not attempted to reproduce this on any other operating systems.

[Rachael]

Sounds like the case-sensitivity bug reared its ugly head again.

[Graf Zahl]

Sounds like the case-sensitivity bug reared its ugly head again.

What makes you think that?

It fails while trying to load the vertex data from glbsp-style GL nodes. On Windows this works and the data is definitely there, this needs to be debugged by someone who experiences the problem.

[Rachael]

What makes you think that?

Lucky guess. The main difference between Linux and Windows is the case sensitive file system, and when there's file access problems on Linux that usually tends to be the reason why.

I reproduced the issue pretty easily just by turning the flag on in Windows 11.

Here is a compressed .vhdx that has a folder with case sensitivity enabled. This can be used to easily reproduce the problem listed in this bug report and cause the crash. The crash is the same on Windows, but only with the flag enabled.
https://drive.google.com/file/d/1IXc5J- ... sp=sharing

Do not open the .vhdx itself with 7-zip - even though it will open and can extract the contents, doing so will strip the important file system flags that are needed for this test. The only way to complete this test successfully is to mount the .vhdx natively which creates a virtual hard drive in your system, and add the provided top-level folder as a -file parameter with gzdoom.

If you've never used .vhd's or .vhdx's before in Windows, it can mount them natively, this should give you an overview of how to do so:
https://learn.microsoft.com/en-us/windo ... hard-disks

Alternatively, you can set any empty folder as case-sensitive and then extract the OP's test into it:

Code: Select all

fsutil.exe file setCaseSensitiveInfo "C:\path\to\your empty folder" enable

[Graf Zahl]

That reproduces the problem but it's not a case sensitivity issue. This happens when you -file a folder that contains maps with glbsp-style GL nodes. In this particular case (and only this case) the container object for the map WAD gets the wrong path set and trying to open its content will inevitably fail.