ZDoom

Kan3x wrote: ↑Tue Jan 16, 2024 2:12 pm At first, I just thought that calling for S_PauseSound in InitEffect would have done the trick, but apparently I still have to give the player the timefreezer flag for the sound pausing function to work :/

Kan3x wrote: ↑Tue Jan 16, 2024 2:12 pm Not only that, but if I don't have this bit

Code: Select all

for(int i = 0; i < MAXPLAYERS; ++i) {
	if (playeringame[i] && players[i].timefreezer != 0) {
		return;
	}
}

in my EndEffect, the game crashes whenever the powerup ends and this is making me even more confused...

Kan3x wrote: ↑Tue Jan 16, 2024 2:12 pm Noticing that when the player has this powerup active every sound is paused (good) except for when he picks up items (?), I started to think of a way to play a specific sound when the powerup activates (or even when it's active until it ends), but for now I got no luck.
Is there a way?

Kan3x wrote: ↑Tue Jan 16, 2024 2:12 pm Any help in understanding what is going on and how to play a specific sound with this powerup is highly appreciated! thx

class Deafen : Powerup
{
    Default
    {
        Powerup.Duration -3;
    }
    
    override void InitEffect()
    {    
        if (Owner == null || Owner.player == null) 
        {
            return;
        }
        
        Super.InitEffect();
        
        if (Owner.PlayerNumber() == consoleplayer)
        {
            S_PauseSound(false, false);
        }

        Owner.player.timefreezer = 1;
    }
    
    override void EndEffect() 
    {
        if (Owner == null || Owner.player == null) 
        {
            return;
        }
        
        Owner.player.timefreezer = 0;
        
        if (Owner.PlayerNumber() == consoleplayer)
        {
            S_ResumeSound(false);
        }

        Super.EndEffect();
    }
}

Player701 wrote: ↑Wed Jan 24, 2024 4:40 am This is because the engine is coded to automatically resume sound if none of the in-game players have timefreezer set to a non-zero value.

Player701 wrote: ↑Wed Jan 24, 2024 4:40 am I could not reproduce the crash. Are you by chance using an outdated release of GZDoom? Try 4.11.3.

Player701 wrote: ↑Wed Jan 24, 2024 4:40 am I think you have to use the flag CHANF_NOPAUSE for this to work. Item pickup sounds use this flag as well.

Player701 wrote: ↑Wed Jan 24, 2024 4:40 am Well, basically, the timefreezer field is used to track if players are allowed to move when the time-freeze effect is active. If non-zero, the player can move, otherwise they cannot. In multiplayer, when someone activates the time-freezer powerup, they and their teammates have this field set to a non-zero value to allow movement. It also uses different bits for each player to allow multiple powerups to be active simultaneously, as well as properly handle their deactivation.

Player701 wrote: ↑Wed Jan 24, 2024 4:40 am For your Deafen powerup to work correctly, it is sufficient to set the value for the owning player only since no one actually gets frozen in the first place. Also, unless your intention is to deafen all players, you should only call S_PauseSound for the console player only:

Player701 wrote: ↑Wed Jan 24, 2024 4:40 am Note, however, that one way or another, you will lose compatibility with the actual time-freezer powerup, so I don't see a need to overcomplicate the code. IMO, it'd be better to suggest a feature that would allow modders to alter the player's hearing range via ZScript.

Kan3x wrote: ↑Thu Jan 25, 2024 11:44 am Couldn't I just check if the level is frozen (.IsFrozen()>0) in Tick() for example directly in this powerup and end the effect or directly destroy it if it is, this way I won't restore the sound for the player with this power?

class Deafen : Powerup
{
    Default
    {
        Powerup.Duration -3;
    }

    // Using this value should avoid conflicts with actual time-freeze powerups
    // (they use 1 shifted by 0..MAXPLAYERS-1 inclusive)
    const TIMEFREEZER_VAL = 1 << MAXPLAYERS;

    override void InitEffect()
    {    
        if (Owner == null || Owner.player == null) 
        {
            return;
        }

        Super.InitEffect();

        if (!Level.isFrozen() && Owner.PlayerNumber() == consoleplayer)
        {
            S_PauseSound(false, false);
        }

        Owner.player.timefreezer |= TIMEFREEZER_VAL;
    }

    override void DoEffect()
    {
        if (Level.isFrozen())
        {
            // This will also call EndEffect
            Destroy();
        }
    }

    override void EndEffect() 
    {
        if (Owner == null || Owner.player == null) 
        {
            return;
        }

        Owner.player.timefreezer &= ~TIMEFREEZER_VAL;

        if (!Level.isFrozen() && Owner.PlayerNumber() == consoleplayer)
        {
            S_ResumeSound(false);
        }

        Super.EndEffect();
    }
}

Player701 wrote: ↑Thu Jan 25, 2024 12:09 pm The only way out of this that I can see is indeed the same one you have suggested: to check for Level.isFrozen() every tick while the effect is active, cancelling it immediately if the result is true. You can avoid a conflict this way, but it still won't allow both effects to coexist.

Chris wrote: ↑Thu Jan 25, 2024 12:33 pm It's important to note that pausing sounds does just that: it pauses them. They will resume exactly where they left off when the effect is over. So if you start a sound like an explosion, pause the sounds for a bit, then when you unpause the sounds sometime later, the explosion sound will continue immediately at normal volume from where it stopped. All pausable sounds started during that time will also start simultaneously. In effect, sounds are just delayed as if waiting for the player to hear them. If the idea is to simulate the player being deafened, that's not what should happen. You instead want sounds to play uninterrupted, but turn their volume way down, and slowly bring their volume back up to normal as the effect wears off. I don't know if there's any script functions that can adjust the volume of sounds dynamically like that, but trying to use a pause effect to simulate it will have apparent side-effects.