Screen.DrawShapeFill should read Color as RGB, not BGR

Remember, just because you request it, that doesn't mean you'll get it.

Moderator: GZDoom Developers

User avatar
kevansevans
Spotlight Team
Posts: 420
Joined: Tue Oct 05, 2010 12:04 am
Graphics Processor: nVidia with Vulkan support

Screen.DrawShapeFill should read Color as RGB, not BGR

Post by kevansevans »

https://zdoom.org/wiki/DrawShapeFill

Currently, passing in a color for Screen.DrawShapeFill will be read as BGR. Meaning if I put in a purely red hex code Color("FF0000"), it'll get read as a blue hex code Color("0000FF"). This is frustratingly annoying and inconsistent with everything else that accepts a Color type.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49096
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Screen.DrawShapeFill should read Color as RGB, not BGR

Post by Graf Zahl »

Too late unfortunately. It was an external contribution and I have no idea why someone thought it was smart to do so.
User avatar
Caligari87
Admin
Posts: 6184
Joined: Thu Feb 26, 2004 3:02 pm
Preferred Pronouns: He/Him

Re: Screen.DrawShapeFill should read Color as RGB, not BGR

Post by Caligari87 »

Is this something that could be tied to a future ZScript version gate? <=4.10 interprets the parameter as BGR, >4.10 interprets as RGB? It's conceivable the only impact for the change would be visual, if it's misused under the wrong version.

8-)
User avatar
kevansevans
Spotlight Team
Posts: 420
Joined: Tue Oct 05, 2010 12:04 am
Graphics Processor: nVidia with Vulkan support

Re: Screen.DrawShapeFill should read Color as RGB, not BGR

Post by kevansevans »

Caligari87 wrote: Thu May 04, 2023 1:43 pm Is this something that could be tied to a future ZScript version gate? <=4.10 interprets the parameter as BGR, >4.10 interprets as RGB? It's conceivable the only impact for the change would be visual.

8-)
Was about to pitch this, as I've been under the impression this was one of the reasons why we can specify a version minimum.

Return to “Feature Suggestions [GZDoom]”