https://zdoom.org/wiki/DrawShapeFill
Currently, passing in a color for Screen.DrawShapeFill will be read as BGR. Meaning if I put in a purely red hex code Color("FF0000"), it'll get read as a blue hex code Color("0000FF"). This is frustratingly annoying and inconsistent with everything else that accepts a Color type.
Screen.DrawShapeFill should read Color as RGB, not BGR
Moderator: GZDoom Developers
-
kevansevans
- Spotlight Team
- Posts: 418
- Joined: Tue Oct 05, 2010 12:04 am
- Graphics Processor: nVidia with Vulkan support
-
Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 48870
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Screen.DrawShapeFill should read Color as RGB, not BGR
Too late unfortunately. It was an external contribution and I have no idea why someone thought it was smart to do so.
-
Caligari87
- Admin
- Posts: 6143
- Joined: Thu Feb 26, 2004 3:02 pm
- Preferred Pronouns: He/Him
Re: Screen.DrawShapeFill should read Color as RGB, not BGR
Is this something that could be tied to a future ZScript version gate? <=4.10 interprets the parameter as BGR, >4.10 interprets as RGB? It's conceivable the only impact for the change would be visual, if it's misused under the wrong version.
-
kevansevans
- Spotlight Team
- Posts: 418
- Joined: Tue Oct 05, 2010 12:04 am
- Graphics Processor: nVidia with Vulkan support
Re: Screen.DrawShapeFill should read Color as RGB, not BGR
Was about to pitch this, as I've been under the impression this was one of the reasons why we can specify a version minimum.Caligari87 wrote: ↑Thu May 04, 2023 1:43 pm Is this something that could be tied to a future ZScript version gate? <=4.10 interprets the parameter as BGR, >4.10 interprets as RGB? It's conceivable the only impact for the change would be visual.