[refactoring5]: Blood: Butchers are broken

[sinisterseed]

If they try to melee, they hit the ground, and their vomit just flies above the player's head. Think throwing knives is broken, too.

https://drive.google.com/file/d/1owvPLp ... sp=sharing

[mjr4077au]

This issue starts with commit "- floatified PukeSeqCallback", but the commit before hand (- floatified HackSeqCallback) should be reviewed as well as they both have a similar setup, and therefore both could be wrong.

Seems that the angle of the position vector is no longer factored in, but attempting to fix it in the way I thought it should be fixed did not yield a successful result.

[Graf Zahl]

Ok, I'll check this out later today.

[Graf Zahl]

I cannot test this myself right now, but IMO the problem here is an incorrect length of the vector.
The omission of the angle is intentional, all this code did was taking the angle from the vector and then taking a vector from the angle - all this did was normalize the vector without taking a square root.
Where this went wrong is the fixed point conversion so the ratio of xy vs. z is wrong - but this messy Blood math is too awful to wrap my head around without any ability to test in-game.

[Graf Zahl]

Fixed all 3 issues
The causes were very different, though:

For the vomit the z-offset was incorrectly scaled. xrepeat is Q2.6, but was used as a Build-z value here, meaning it had to be multiplied by 0.25 in floating point space.
The knife had an error in the original code. It added eyeHeight as z-offset, but forgot that this value is in pixels, effectively passing 0.5 as offset. As it just so happens, this attack needs an offset of 0, so the half pixel difference was irrelevant. When floatifying this the value remained unchanged and became far too large.
The melee attack simply forgot to add the scaling when floatified

HackSeqCallback is fine, though. It calculates the correct z-component of the vector.