ACS: APROP_SoundClass

Moderator: GZDoom Developers

User avatar
Shiny Metagross
Posts: 173
Joined: Wed Apr 02, 2014 10:00 pm
Location: USA

ACS: APROP_SoundClass

Post by Shiny Metagross »

https://github.com/coelckers/gzdoom/pull/1333

Hey all, this is my first new feature I have created for GZDoom/Zandronum. I'm very new to C++, but I needed a feature for my mod, so I've developed this extension to SetActorProperty, GetActorProperty, and CheckActorProperty for both ports. So, what is this?

APROP_SoundClass is an extension to SetActorProperty, GetActorProperty, and CheckActorProperty which will allow manipulation of a player class's sound class. The use I have for this is for changing the sound class of a player under conditions where additional player pawns or skins are simply not viable. Could also be used to player aliases under very specific instances that otherwise can't be modified.

I added APROP_SoundClass at index 47 in zdefs.acs. I would attach it, but that's not allowed here.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 48867
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: ACS: APROP_SoundClass

Post by Graf Zahl »

Please check my review in the PR.
User avatar
Shiny Metagross
Posts: 173
Joined: Wed Apr 02, 2014 10:00 pm
Location: USA

Re: ACS: APROP_SoundClass

Post by Shiny Metagross »

Applied the suggested changes to the PR.
User avatar
Shiny Metagross
Posts: 173
Joined: Wed Apr 02, 2014 10:00 pm
Location: USA

Re: ACS: APROP_SoundClass

Post by Shiny Metagross »

Hey, it's been awhile since any review. I went ahead and submitted a new pull request which fixes a lot of issues that I tested with various scenarios. Ultimately the code is more refined than it was before. Please check it when you have the chance.

Thanks.
User avatar
Shiny Metagross
Posts: 173
Joined: Wed Apr 02, 2014 10:00 pm
Location: USA

Re: ACS: APROP_SoundClass

Post by Shiny Metagross »

Still waiting over a month for feedback on my latest changes, so gonna post here again.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 48867
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: ACS: APROP_SoundClass

Post by Graf Zahl »

Sorry, I must have missed it.

Return to “Closed Feature Suggestions [GZDoom]”