[Fixed] [gef2fa6487 regression]ANIMDEFS error on load

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[gef2fa6487 regression]ANIMDEFS error on load

Postby Edward-san » Sun Jan 12, 2020 1:52 pm

When I run gzdoom with DoomRPG, I get this error which didn't appear before the directory fix commit:

Code: Select allExpand view
*lots of warnings*

ANIMDEFS: Can't find FIRESK00
2020-01-12 20:47:24.460793+0100 gzdoom[30046:3204639] Script error, ":animdefs.txt" line 11:
Unknown texture FIRESK99


Command line to run:

Code: Select allExpand view
gzdoom -iwad DOOM2.WAD -file DoomRPG/DoomRPG



I suppose this can only be reproduced if the DoomRPG source at github is downloaded in the wads path.

[edit]Full log before and after the change:

Spoiler: before


Spoiler: after


so the number of warnings increased drastically.
Edward-san
Mathematics is the language with which God has written the universe. (Galilei)
 
Joined: 17 Oct 2009

Re: [gef2fa6487 regression]ANIMDEFS error on load

Postby _mental_ » Sun Jan 12, 2020 3:06 pm

It had nothing to do with ANIMDEFS. It's just directory traversal was broken on non-Windows platforms. Fixed in 7092a0a.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [gef2fa6487 regression]ANIMDEFS error on load

Postby Graf Zahl » Sun Jan 12, 2020 3:22 pm

Ugh. How long has that bug been there? It apparently never got noticed because that code wasn't used for critical operations before.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [gef2fa6487 regression]ANIMDEFS error on load

Postby drfrag » Sun Jan 12, 2020 4:05 pm

Since "- fixed: The directory scanner for reading a directory into the WAD file system and ScanDirectory were not Unicode capable on Windows." i think.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: [gef2fa6487 regression]ANIMDEFS error on load

Postby Graf Zahl » Sun Jan 12, 2020 4:12 pm

I mean, since when was the bug in the code that _mental_ fixed. This is old stuff that has always been there, I just replaced the existing directory scanner in the WAD manager.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests