[Fixed] 4-3-1 SoundsequenceOnSector confusion

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

4-3-1 SoundsequenceOnSector confusion

Postby zhadoom » Sat Jan 11, 2020 3:55 am

Hello developers! :D

Here's a report on a small bug with the ACS command SoundsequenceOnSector. This takes arguments determining a sound to be attached to a sector, its ceiling, interior or floor. In 4-3-1, there's a confusion regarding these arguments. Ceiling and floor seem to be flipped.

Instruction to reproduce: Run the map attached below in 4.2.4 first. When the platform is up, you here the wind sound assigned to the ceiling with the sky texture. When the platform goes down, you here the water sound belonging to the floor texture. After this, please run the map in 4.3.1 and listen, what happens. :wink:

Thanks a lot
Kind regards
zhd
You do not have the required permissions to view the files attached to this post.
zhadoom
 
Joined: 04 Feb 2019

Re: 4-3-1 SoundsequenceOnSector confusion

Postby _mental_ » Sat Jan 11, 2020 5:12 am

This commit changed CHAN_... constants. The related condition is no longer correct. What do we need to adjust, constants or bound checking?
_mental_
 
 
 
Joined: 07 Aug 2011

Re: 4-3-1 SoundsequenceOnSector confusion

Postby Graf Zahl » Sat Jan 11, 2020 5:19 am

That change was accidental. I think it's best to revert these constants and do a new point release ASAP.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: 4-3-1 SoundsequenceOnSector confusion

Postby _mental_ » Sat Jan 11, 2020 5:27 am

Fixed in f9fa07d.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests