[Fixed] PICKUP_PISTOL_DROPPED error

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

PICKUP_PISTOL_DROPPED error

Postby Flynn Worthingford » Sun Jan 05, 2020 12:24 am

Upon picking up a pistol, the message "PICKUP_PISTOL_DROPPED" is printed, instead of "Picked up a pistol."
Flynn Worthingford
 

Re: PICKUP_PISTOL_DROPPED error

Postby Graf Zahl » Sun Jan 05, 2020 1:24 am

Works for me. I get the correct text.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: PICKUP_PISTOL_DROPPED error

Postby Flynn Worthingford » Sun Jan 05, 2020 4:49 pm

Just tried again with 4.3.1 and it's still happening to me.
Flynn Worthingford
 

Re: PICKUP_PISTOL_DROPPED error

Postby wildweasel » Sun Jan 05, 2020 6:24 pm

Flynn Worthingford wrote:Just tried again with 4.3.1 and it's still happening to me.

What is your language set to? When you installed 4.3.1, did you also update gzdoom.pk3?
User avatar
wildweasel
change o' pace.
Moderator Team Lead
 
Joined: 16 Jul 2003

Re: PICKUP_PISTOL_DROPPED error

Postby Flynn Worthingford » Sun Jan 05, 2020 7:19 pm

Language is set to Auto, and system language is English US. I'm using the gzdoom.pk3 included with the download file for GZDoom 4.3.1.
Flynn Worthingford
 

Re: PICKUP_PISTOL_DROPPED error

Postby Rachael » Sun Jan 05, 2020 8:42 pm

Don't hate me, but...


I'm not getting this, either.

Did you update your game_support.pk3 file? The release was compiled completely from scratch and I just confirmed the presence of game_support.pk3 in the archive.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: PICKUP_PISTOL_DROPPED error

Postby Flynn Worthingford » Sun Jan 05, 2020 8:58 pm

Yes, I copied and pasted every file in the download zip, replacing any previous files.
And to save a step, in case anyone was going to ask, this was tested with a fresh .ini as well. A clean install. I also used -noautoload just on the off chance of something external being loaded.
Flynn Worthingford
 

Re: PICKUP_PISTOL_DROPPED error

Postby Flynn Worthingford » Sun Jan 05, 2020 9:08 pm

I have a correction to make to that last statement: there was an external file being loaded, after all. And said external file contains a LANGUAGE lump which defines a string for PICKUP_PISTOL_DROPPED in Italian (no other languages).

Removing this file stops the error, even though the [enu] definition of PICKUP_PISTOL_DROPPED was never touched.
Flynn Worthingford
 

Re: PICKUP_PISTOL_DROPPED error

Postby wildweasel » Sun Jan 05, 2020 9:52 pm

Can you direct us to this external file? Because while my GZDoom install is still somewhat old (4.2.4), a cursory search through the language.csv file in game_support.pk3 does not show me any strings called "pickup_pistol_dropped".
User avatar
wildweasel
change o' pace.
Moderator Team Lead
 
Joined: 16 Jul 2003

Re: PICKUP_PISTOL_DROPPED error

Postby Flynn Worthingford » Sun Jan 05, 2020 10:00 pm

The external file was of my own creation, and it being loaded was my own fault. However, I don't see how this file *should* be causing this issue, and it indeed only started happening recently.

To reproduce this issue, you only need a language lump like the following:

[enu default]
PICKUP_MINIGUN = "You got the minigun!";

[ita]
PICKUP_PISTOL_DROPPED = "Hai trovato una pistola.";


...with a single string under [enu default] (doesn't matter what it is), and then the string in question under some other language.

For reference, wildweasel, gzdoom.pk3's language.csv is where the engine's PICKUP_PISTOL_DROPPED string can be found.
Flynn Worthingford
 

Re: PICKUP_PISTOL_DROPPED error

Postby Rachael » Sun Jan 05, 2020 11:56 pm

I am not 100% sure, but I believe that there is still a bug here. I don't think it should be clearing the English string if there's an entry for Italian for that same string.

I am reopening this.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: PICKUP_PISTOL_DROPPED error

Postby _mental_ » Mon Jan 06, 2020 2:23 am

Fixed in 83f46c4.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests