Important notice:A_StartSound and deprecation of A_PlaySound

[Graf Zahl]

I just made a final change to the newly added ZScript sound API for unlimited sound channels:

A_StartSound had two boolean parameters that are now folded into the flag word.
- the looping flag is identical with passing 'CHANF_LOOP|CHANF_NOSTOP', so now these two flags need to be set instead. There's a convenience definition of CHANF_LOOPING that does this with one value
- the local flag must now be specifed as CHANF_LOCAL.

As a result of this change, all code from the last two weeks that used A_StartSound needs to be reviewed! If optional parameters are omitted this is very likely to produce incorrect results without a compiler error!
In addition, all internal code still using A_PlaySound has been converted to A_StartSound and A_PlaySound officially been deprecated.

[Nash]

Thank you for this amazing new feature (unlimited sound channels per actor).

[Matt]

Sweet.

Does this mean we can plug in any arbitrary number for the channel parameter, or is this just in reference to the effective result of CHANF_OVERLAP?

[Graf Zahl]

You can plug in any number, except 0 and -1.
0 is still CHAN_AUTO and -1 is being used by some function as a "don't care" substitute when checking state.