[06ad607] Crash when selecting Option Search

[vsonnier]

Hi,
When I select Option Search in the latest GZDoom master, I got a wonderful crash like:

Code: Select all

VM execution aborted: array access out of bounds. Negative current index = -1

Called from OptionMenu.Init at gzdoom.pk3:zscript/ui/menu/optionmenu.zs, line 110
Called from os_Menu.Init at gzdoom.pk3:zscript/ui/menu/search/menu.zs, line 13
Called from OptionMenuItemSubmenu.Activate at gzdoom.pk3:zscript/ui/menu/optionmenuitems.zs, line 126
Called from OptionMenu.MenuEvent at gzdoom.pk3:zscript/ui/menu/optionmenu.zs, line 349
Called from Menu.SetMenu [Native]

Has anyone else got this ?

[drfrag]

It crashes since "add empty line after standard options".

[Graf Zahl]

Oops. Here goes today's release...

[3saster]

Seems a simple size check fixes it:

Code: Select all

		if(mDesc.mItems.size() > 0)
		{
			let last = mDesc.mItems[mDesc.mItems.size() - 1];
			bool lastIsText = (last is "OptionMenuItemStaticText");
			if (lastIsText)
			{
				String text = last.mLabel;
				bool lastIsSpace = (text == "" || text == " ");
				if (lastIsSpace)
				{
					mDesc.mItems.Pop();
				}
			}
		}

[_mental_]

Fixed in 526a576.