[Fixed] [ae57bc7] Manually spawned dynlights don't work

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[ae57bc7] Manually spawned dynlights don't work

Postby Marisa Kirisame » Mon Aug 19, 2019 5:10 pm

Since this commit any dynamic light actors that are spawned won't work unless one disables and re-enables dynamic lights in the options. This breaks a wide variety of mods.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
Graphics Processor: nVidia with Vulkan support

Re: [ae57bc7] Manually spawned dynlights don't work

Postby _mental_ » Tue Aug 20, 2019 9:25 am

Made this PR with the fix. Honestly, overall dynamic light setup is quite fragile. There are two pretty distinct ways to create them. C++ side has not so trivial blend of both ways though.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [ae57bc7] Manually spawned dynlights don't work

Postby Marisa Kirisame » Wed Aug 21, 2019 6:59 am

This fix still hasn't been added?
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
Graphics Processor: nVidia with Vulkan support

Re: [ae57bc7] Manually spawned dynlights don't work

Postby Graf Zahl » Wed Aug 21, 2019 7:09 am

I haven't had time yet to review it.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [ae57bc7] Manually spawned dynlights don't work

Postby drfrag » Mon Aug 26, 2019 2:22 pm

This bug looks important, what about that PR?
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: [ae57bc7] Manually spawned dynlights don't work

Postby Graf Zahl » Mon Aug 26, 2019 3:17 pm

Sorry, I've been busy elsewhere the last few days. _mental_ made some remarks in the PR I first need to check before applying it.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [ae57bc7] Manually spawned dynlights don't work

Postby Marisa Kirisame » Tue Aug 27, 2019 2:51 am

I've been using that PR for a week now and it doesn't seem to cause any issues.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
Graphics Processor: nVidia with Vulkan support

Re: [ae57bc7] Manually spawned dynlights don't work

Postby Graf Zahl » Tue Aug 27, 2019 5:17 am

I know that it works, that's not the problem. But I cannot apply a PR if that PR also hints at something wrong at a deeper level.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [ae57bc7] Manually spawned dynlights don't work

Postby drfrag » Tue Aug 27, 2019 6:00 am

I just wanted to be sure you didn't forget as you were doing other stuff.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: [ae57bc7] Manually spawned dynlights don't work

Postby Graf Zahl » Mon Sep 02, 2019 5:20 am

I went ahead and merged it, it's unlikely that I'd do some deeper investigation in the near future anyway.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest