Crash Report Truncating Command Line?

[Enjay]

I just reported a crash with Doom Tournament and when looking inside the crash report, I noticed that the command line was logged in local.txt like this:

Code: Select all

GZDoom version g3.8pre-747-g55e00f350 (55e00f350bc4df3a3deea1aaef7227b73c26de85)
Command line: "

Wad 0: gzdoom.pk3

However, the command line was actually:




This seems likely to be unintended, hence the report.

[_mental_]

Fixed in 025e502.

Please note that this didn't make crash reports Unicode-ready. I'm curious, do we really need it there?
If so, should the text be processed as wide characters and converted to UTF-8 before saving to a file?

[Graf Zahl]

Ideally it should convert the output from GetCommandLineW to UTF-8, but I do not think that this warrants any real work for the few cases where it's necessary.

BTW, I'd really wish that these stupid A/W #defines in windows.h could be disabled, they were the biggest roadblock in the transitioning phase because they let some code silently fail where a proper function would have caused a compilation error.