[Fixed] [g3.7pre-754-g888af3d68] Not crash on closing console

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[g3.7pre-754-g888af3d68] Not crash on closing console

Postby m8f » Sat Dec 08, 2018 10:54 am

Steps to reproduce:
1. Launch GZDoom;
2. Open console by assigned toggleconsole key (grave accent - '`' - in my case).
Note 1: I'm using Dvorak Programming keyboard layout, and actually this key (without Shift) is '$'. For some reason, this key is recognized by GZDoom as grave accent. I wonder if this is related to the problem or not.
3. Close console by using the same key;
4. Crash.

Note 2: if the console is closed by Esc key, no crash happens.

Spoiler:


No crash log is generated.

Gnome version 3.22.2, Debian GNU/Linux 9 (stretch) 64-bit.
Last edited by m8f on Sun Dec 09, 2018 10:18 am, edited 1 time in total.
User avatar
m8f
the dreamer
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff

Re: [g3.7pre-754-g888af3d68] Crash on closing console

Postby _mental_ » Sun Dec 09, 2018 5:18 am

First of all, this is not a crash. Try to run Release configuration and "mysteriously" it will go away.
Actually, this is indicated clearly in the log: Assertion 'string[0] != '$'' failed.

As for assertion itself, I think it's wrong. It fails when '$' is entered in console as the first character of a command. Same for menus, chat line, etc.
Most likely, the idea was to catch untranslated text lines. It seems to be impossible to detect such thing correctly there.

About Dvorak keyboard, I have no idea. Could be an issue with SDL or our SDL backend.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [g3.7pre-754-g888af3d68] Crash on closing console

Postby Graf Zahl » Sun Dec 09, 2018 5:25 am

Yes, that assert looks like a leftover from working on that code.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [g3.7pre-754-g888af3d68] Crash on closing console

Postby _mental_ » Sun Dec 09, 2018 6:02 am

OK, this assertion is removed in 40f77e5.

Unfortunately, I cannot check on Linux at the moment. macOS doesn't have Dvorak Programming keyboard input source.
_mental_
 
 
 
Joined: 07 Aug 2011

Re: [g3.7pre-754-g888af3d68] Not crash on closing console

Postby m8f » Sun Dec 09, 2018 10:19 am

The fix is confirmed. Thanks!
User avatar
m8f
the dreamer
 
 
 
Joined: 29 Dec 2017
Discord: m8f#0629
Github ID: mmaulwurff


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest