Glitch with do effect function

[Apeirogon]

I try replicate fractal doom effect on monsters using inventory item with override od effect.
But it dont want to work as I want.

Here video
https://youtu.be/GZ_xEDuujTo

Can some one look at code and say what I missed?

---

Code: Select all

class mutagen : inventory
{
	double result_value;
	double target_result_value;
	default {inventory.amount 1;}
}
//////////////
class fractal_mutation : mutagen
{
	double max_health;
	double current_health;
	double previous_health;
	double default_radius;
	double default_height;
	bool master_check;
	
override void AttachToOwner(Actor user)
{
	max_health = user.health;
	current_health = user.health;
	previous_health = user.health;
	
	default_radius = user.radius;
	default_height = user.height;
	result_value = 1;
	if(user.master != null){master_check = true;}
	
	super.AttachToOwner(user);
}

override void doeffect()
{
	if(owner.health<=1){return;}
	if(owner.radius <= 1 || owner.radius <= 1) {owner.a_die(); return;}
	if (master_check == true)
	{
		master_check = false;
		
		double constanta = fractal_mutation(owner.master.findinventory("fractal_mutation") ).result_value;
		
		owner.A_setscale(constanta);
		owner.a_setsize(default_radius * constanta, default_height * constanta);
		owner.a_sethealth(max_health * constanta);
		
		max_health = owner.health;
		current_health = owner.health;
		previous_health = owner.health;
	}
	
	current_health = owner.health;
	if(current_health == previous_health){return;}

	result_value = current_health/max_health;
	owner.A_SetScale(result_value);
	owner.a_setsize(default_radius*result_value, default_height*result_value);
	if(owner.radius >= 1 && owner.height >= 1)
	{
		owner.a_spawnitemex(owner.getclassname(),0,0,0,
		frandom(- owner.radius,owner.radius),
		frandom(- owner.radius,owner.radius),
		frandom(0,owner.height),0, SXF_SETMASTER|sxf_nocheckposition);
		owner.a_givetochildren("fractal_mutation",1);
	}

	previous_health = owner.health;
}

}

[Matt]

What are you trying to do, and what happens instead of that?

[Apeirogon]

In fractal doom every enemy after death spawn several monsters of the same type as monster that died. But this newborn monsters have smaller hitbox, damage, amount of maximum health, etc.

I try make similar thing. After monster receive hit it must "split" in two monsters (more preciesly, damaged monster must shrink in size, reduce it sprite size, damage, health, etc; then spawn another monster of the same type, which look on original monster and set self hitdbox size, damage, etc. equal to it).

But insted of that, sometimes monster which spawns set self hitdbox size, damage, etc. greater than actor that spawn him. And I cant understand why.

[Matt]

You are using "current_health" divided by "max_health".

But "max_health" is not the starting max health but the max health of the previous monster.

So you could start with a demon with max_health 150, then current_health 100, split into 2x monsters with constanta = 100/150 = 0.67.

But then later one of those guys gets shot, their max_health is 100, their current_health is 70, split into 2x monsters with constanta = 70/100 = 0.7.

If instead of owner/user.health you set max_health to always use the full-size monster's default health (owner/user.spawnhealth()), then in the above example the monsters' sizes would be:

100/150 = 0.67
70/150 = 0.47

[Apeirogon]

I forgot basic math...

I need some rest from gzdoom...

[Matt]

I had to run it a couple times and add some lines logging the results at each step before I could see what was going on.

Problems like that would be a lot easier to notice if you do everything at that A_SpawnItemEx step instead of splitting it off into the AttachToOwner.

Remember that pointers can be set for newly created actors and inventory items using the following:

Code: Select all

int bbb;actor aaa;
[bbb,aaa]=xyz.A_SpawnItemEx("ActorName",flags:SXF_TRANSFERFLAGS|SXF_SETMASTER|SXF_NOCHECKPOSITION); 

and

Code: Select all

xyz.A_GiveInventory("ItemName");
inventory abc=xyz.FindInventory("ItemName"); 

or

Code: Select all

xyz.A_GiveInventory("ItemName");
let def=ItemName(xyz.FindInventory("ItemName")); 

which would let you use "def.ppp" where ppp is a property that only ItemName has.

[Apeirogon]

I made so, because I dont know how, and can I, change variables directly from master.

And what means "xyz."?

[Matt]

"xyz" is just the name of the pointer variable, it can be any unique name you want. Remember that in ZScript you're not limited to master/target/tracer.

The example code I posted is specifically so that you can do these changes from the master.

You set up a new pointer variable, have it point to the actor created by A_SpawnItemEx, then use that pointer to make changes to the actor that was given.

Same thing with the item: You set up a new pointer variable, have it (using FindInventory) point to the item created by A_GiveInventory, then use that pointer to make changes to the item that was given.

More about pointers here.