[Added] Rail Puff Support for Floors and Ceilings

Moderator: Developers

Rail Puff Support for Floors and Ceilings

Postby Major Cooke » Thu Jan 14, 2016 12:24 pm

Pull Request

A simple change, this adds the ability for puffs to spawn on floors and ceilings if the puffs have ALWAYSPUFF specified. In a way, this is technically a bugfix and a feature.

I went this route and added support for the flag because it was either this, or expanding bullet attack functionalities with the abilities to provide offsets from the shooter which no one can really see without a beam. This I feel was much simpler.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: Rail Puff Support for Floors and Ceilings

Postby Nash » Sat Jan 16, 2016 3:05 pm

This broke my line traces (spawned with LineAttack) that rely on the puffs automatically disappearing when it hits sky ceilings and floors (and also required +ALWAYSPUFF so that they collide with live actors). Please revert or add an option for your new behavior.
User avatar
Nash
Nash Muhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia

Re: Rail Puff Support for Floors and Ceilings

Postby Graf Zahl » Sat Jan 16, 2016 3:16 pm

How can this affect your traces spawned with P_LineAttack, when the change is in P_RailAttack?

That said, it should definitely have a sky check added.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Rail Puff Support for Floors and Ceilings

Postby Major Cooke » Sat Jan 16, 2016 3:31 pm

Better yet, a flag to allow the +ALWAYSPUFF flag. Not just skies.
User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846

Re: Rail Puff Support for Floors and Ceilings

Postby Graf Zahl » Sat Jan 16, 2016 3:43 pm

Skies should be off by default, unless the SKYEXPLODE flag is specified. No more needless options.
User avatar
Graf Zahl
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Rail Puff Support for Floors and Ceilings

Postby Major Cooke » Sat Jan 16, 2016 5:59 pm

User avatar
Major Cooke
The road to Hell is paved in the carrion she leaves behind.
 
Joined: 28 Jan 2007
Discord: Major Cooke#0846


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 0 guests