My guess is because you have to input the action special as a number, rather than by name. Using a name is much easier to read and understand what the code will do, rather than having to look up the number of the action special.Ceeb wrote:Why, exactly, is the use of [wiki]A_CallSpecial[/wiki] so frowned upon?
Ceeb wrote:Why, exactly, is the use of [wiki]A_CallSpecial[/wiki] so frowned upon?
These numbers aren't going to be changed because maps necessarily refer to specials by their numbers.Slasher wrote:More importantly, by using the name of the action special, the internal number can be changed if necessary. If a number is used directly, and later the number is changed such that it isn't used to refer to that action special anymore for some reason, it will break compatibility.
Code: Select all
#include "zcommon.acs"
function void RunSpecial(int number,int arg1,int arg2,int arg3,int arg4,int arg5)
{
Switch(number)
{
//1 Polyobj_StartLine
Case 2: Polyobj_RotateLeft (arg1, arg2, arg3); break;
Case 3: Polyobj_RotateRight (arg1, arg2, arg3); break;
Case 4: Polyobj_Move (arg1, arg2, arg3, arg4); break;
//5 Polyobj_ExplicitLine
Case 6: Polyobj_MoveTimes8 (arg1, arg2, arg3, arg4); break;
Case 7: Polyobj_DoorSwing (arg1, arg2, arg3, arg4); break;
Case 8: Polyobj_DoorSlide (arg1, arg2, arg3, arg4, arg5); break;
//9 Line_Horizon
Case 10: Door_Close (arg1, arg2); break; //no arg3 in ACC 1.49
Case 11: Door_Open (arg1, arg2, arg3); break;
Case 12: Door_Raise (arg1, arg2, arg3, arg4); break;
Case 13: Door_LockedRaise (arg1, arg2, arg3, arg4, arg5); break;
Case 14: Door_Animated (arg1, arg2, arg3); break; //no arg4 in ACC 1.49
Case 15: Autosave (); break;
//16 Transfer_WallLight
Case 17: Thing_Raise (arg1); break;
Case 18: StartConversation (arg1, arg2); break;
Case 19: Thing_Stop (arg1); break;
Case 20: Floor_LowerByValue (arg1, arg2, arg3); break;
//..about 235 more specials to go..
default:
PrintBold(s:"Unknown special!");
}
}
Hexen format maps actually do not use a translator lump at all!Worst wrote:I think the numbers used are the same that you use with linedefs..so if those would be later on changed, it would break pretty much every doom/hexen format map that doesnt use its own translator lump for its linedef specials.
