[Fixed] "kill monsters" doesn't always work

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
SargeBaldy
Posts: 366
Joined: Tue Jul 15, 2003 3:49 pm
Location: Oregon

"kill monsters" doesn't always work

Post by SargeBaldy »

i noticed playing claustrophobia that "kill monsters" only deals a certain amount of damage to all monsters rather than kill them outright. the boss at the end is tough enough to take 2 "kill monster"s to die. wouldn't it make more sense to just call something to kill all the monsters rather than deal them all a bunch of damage so this kind of stuff doesn't happen? or at least double the amount of damage dealt..
User avatar
Cutmanmike
Posts: 11349
Joined: Mon Oct 06, 2003 3:41 pm
Operating System Version (Optional): Windows 10
Location: United Kingdom

Post by Cutmanmike »

I noticed this, but having a monster with such huge health shouldn't need to be killed that easy. Just use it multiple times
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49193
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: "kill monsters" doesn't always work

Post by Graf Zahl »

SargeBaldy wrote:i noticed playing claustrophobia that "kill monsters" only deals a certain amount of damage to all monsters rather than kill them outright. the boss at the end is tough enough to take 2 "kill monster"s to die. wouldn't it make more sense to just call something to kill all the monsters rather than deal them all a bunch of damage so this kind of stuff doesn't happen? or at least double the amount of damage dealt..

I think the better solution would be to use the maximum of 10000 and the monster's current health to preserve the current effect as good as possible. I noticed this, too, yesterday because I played a WAD which had a boss with over 15000 health points which didn't die with one 'kill monsters'.
User avatar
Enjay
 
 
Posts: 26695
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland

Post by Enjay »

Kill monsters used to kill all monsters, but now it does not affect dormant ones. Not complaining, because I know this is by design, just mentioning seeing as how it seems mildly relevant.
User avatar
HotWax
Posts: 10002
Joined: Fri Jul 18, 2003 6:18 pm
Location: Idaho Falls, ID

Post by HotWax »

If kill monsters couldn't deal more damage than the current health of the monster it was killing, then the monster wouldn't gib when it died.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49193
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Post by Graf Zahl »

HotWax wrote:If kill monsters couldn't deal more damage than the current health of the monster it was killing, then the monster wouldn't gib when it died.

Of course. See my suggestion for this problem.
User avatar
Matt
Posts: 9696
Joined: Sun Jan 04, 2004 5:37 pm
Preferred Pronouns: They/Them
Operating System Version (Optional): Debian Bullseye
Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia

Post by Matt »

What about making the affected monsters go into their exploding, or if there isn't one, death animation instead of dealing with health at all?
User avatar
HotWax
Posts: 10002
Joined: Fri Jul 18, 2003 6:18 pm
Location: Idaho Falls, ID

Post by HotWax »

Graf Zahl wrote:Of course. See my suggestion for this problem.
Oops, I read your post wrong. I thought you were saying to take away the health of the monster, or 10000 points, whichever is lower. (Which doesn't make sense in any case) :P
Vaecrius wrote:What about making the affected monsters go into their exploding, or if there isn't one, death animation instead of dealing with health at all?
That might screw up various ACS scripts which rely on health to do something, and any internal functions that look at the health of a Thing without paying attention to its current state. (And for all I know, there might be no actual state and the entire game considers HP <= 0 to mean death)
User avatar
Chris
Posts: 2958
Joined: Thu Jul 17, 2003 12:07 am
Graphics Processor: ATI/AMD with Vulkan/Metal Support

Post by Chris »

Why not just deal the thing its current HP + max HP + 1(to ensure explosion) in damage?
User avatar
Bio Hazard
Posts: 4019
Joined: Fri Aug 15, 2003 8:15 pm
Location: ferret ~/C/ZDL $

Post by Bio Hazard »

Chris wrote:ensure explosion
you guys are so violent! :D
User avatar
Giest118
Posts: 2914
Joined: Fri Dec 05, 2003 11:02 pm

Post by Giest118 »

Why do you need the explosion anyway? Isn't just having the monsters dead good enough for you?
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49193
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Post by Graf Zahl »

HotWax wrote:(And for all I know, there might be no actual state and the entire game considers HP <= 0 to mean death)

You guessed exactly right. health<=0 is the primary check for dead monsters. Of course you can reduce the health to a negative value manually and then call the Die method explicity but killing monsters has always been done by damaging them so I guess it should stay that way. I never bothered to check whether some part of the code actually requires it.
User avatar
Xaser
 
 
Posts: 10773
Joined: Sun Jul 20, 2003 12:15 pm

Post by Xaser »

explosion > death*1000
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49193
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Post by Graf Zahl »

Xaser wrote:explosion > death*1000

What's the meaning behind this? For Doom purposes this doesn't make sense! 8-)
User avatar
Xaser
 
 
Posts: 10773
Joined: Sun Jul 20, 2003 12:15 pm

Post by Xaser »

I'm trying to say that 1 explosive death is better than 1000 normal deaths. Yeah, I'm exaggerating, but who cares?

Return to “Closed Bugs [GZDoom]”