HOW TO FIX MyHouse on GZDoom 4.14.0

Need help running G/Q/ZDoom/ECWolf/Zandronum/3DGE/EDuke32/Raze? Did your computer break? Ask here.

Moderator: GZDoom Developers

Forum rules
Contrary to popular belief, we are not all-knowing-all-seeing magical beings!

If you want help you're going to have to provide lots of info. Like what is your hardware, what is your operating system, what version of GZDoom/LZDoom/whatever you're using, what mods you're loading, how you're loading it, what you've already tried for fixing the problem, and anything else that is even remotely relevant to the problem.

We can't magically figure out what it is if you're going to be vague, and if we feel like you're just wasting our time with guessing games we will act like that's what you're really doing and won't help you.
User avatar
Jekyll Grim Payne
Global Moderator
Posts: 1117
Joined: Mon Jul 21, 2008 4:08 am
Preferred Pronouns: He/Him
Graphics Processor: nVidia (Modern GZDoom)

HOW TO FIX MyHouse on GZDoom 4.14.0

Post by Jekyll Grim Payne »

Updated: Xaser uploaded a version containing the fix described below here: https://www.dropbox.com/scl/fi/688xgim6 ... uc343&dl=0

MyHouse is one of the mods that no longer work in 4.14.0 due to fixes to security vulnerabilities. Due to the nature of these fixes, they have to be enforced, so even if a specific project's ZScript version is set to something lower than 4.14.0, it still won't work in GZDoom 4.14.0 unless fixed. The actual fixes to array types were mostly introduced back in 4.11, i.e. quite a while ago, but they weren't enforced back then.

In short:

How to fix MyHouse for GZDoom 4.14.0:
  • Open myhouse.pk3 using either an archive tool like 7-Zip (this is just a zip archive) or SLADE
  • Find the file called zscript
  • In line 75 replace weapons.push(int(weap)); with weapons.push(weap);


Note: it's not possible to make a standalone patch for MyHouse, because the offending code is in the root zscript file, which cannot be overridden by a patch. (If it were in an #included file, it would've been possible, but alas.)
Top

Return to “Technical Issues”